Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Small fixes and improvements #74

Merged
merged 4 commits into from
Nov 21, 2023
Merged

馃悰 Small fixes and improvements #74

merged 4 commits into from
Nov 21, 2023

Conversation

pleonex
Copy link
Owner

@pleonex pleonex commented Nov 21, 2023

Small fixes and improvements:

  • Remove IsPublishable MSBuild property as it's not used.
  • boolean arguments such as incremental or warn-as-error now accept a custom value to set it to false or true via CLI
    • Refactor extension method for arguments.
  • Upgrade StyleCop to latest beta per author recommendation for latest C# support
  • Removed Roslynator analyzer as it gives frequent errors with SDK upgrades.
  • Clean-up old comments and markdown warnings

Checklist:

  • Related code has been tested automatically or manually
  • Related documentation is updated
  • I acknowledge I have read and filled this checklist and accept the
    developer certificate of origin

Acceptance criteria

  • It's possible to assign values to boolean arguments

Follow-up work

None

Example

Setting a command-line value for a boolean type: --incremental=False

@pleonex pleonex added the enhancement New feature or request label Nov 21, 2023
@pleonex pleonex self-assigned this Nov 21, 2023
@pleonex pleonex merged commit 7362137 into main Nov 21, 2023
4 checks passed
@pleonex pleonex deleted the feature/small-fixes branch November 21, 2023 10:35
@pleonex pleonex added this to the vNext milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant