Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Improve NuGet readme and document doc protection tag #76

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

pleonex
Copy link
Owner

@pleonex pleonex commented Nov 23, 2023

Small fixes after testing for the first time to deploy NuGets:

  • By default GitHub pages are not allowed to publish from tag builds. Documented how to allow it.
  • Improve README in NuGets by removing HTML in markdown.
  • Removed trigger on release published as it triggers the build twice. We have already the trigger for git tag pushes.

Quality check list

  • Related code has been tested automatically or manually
  • Related documentation is updated
  • I acknowledge I have read and filled this checklist and accept the
    developer certificate of origin

Acceptance criteria

  • README in NuGet does not contain HTML or images
  • Document how to publish docs from git tag builds

Follow-up work

None

Example

No need.

@pleonex pleonex added the documentation Improvements or additions to documentation label Nov 23, 2023
@pleonex pleonex self-assigned this Nov 23, 2023
@pleonex pleonex merged commit d24f3f8 into main Nov 23, 2023
4 checks passed
@pleonex pleonex deleted the feature/improve-nuget-readme branch November 23, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant