Bring develop up to date with Master #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated slack link
Several options are based on the number of CPUs, which in some cases lead to option default being set to zero: 1 CPU / 2 => 0 (integer division) 1 CPU - 1 => 0 This fixes the problem by ensuring those default are at least one.
Fix option parsing to work with 1 CPU core
felixbuenemann
previously approved these changes
May 4, 2018
felixbuenemann
dismissed
their stale review
Conflicts due to parameter changes in develop.
|
@dweidenfeld You hard coded some of the config values in db83bb6, which is why this PR has merge conflicts. Could you elaborate why you changed the defaults? The commit message of "fixed default values" is not that useful. |
|
@felixbuenemann |
zenjabba
previously approved these changes
May 18, 2018
|
Just a short note: I haven't merged this yet, cause I think it's generally useful to have sane defaults for the parameters and if these are mainly i/o bound, there is not much sense in having the default depend on the number of cpu cores. On the other hand I haven't yet had time to check the defaults dweidenfeld used in develop to see how well they work on low-spec systems regarding cpu and memory. |
The current version of gensupport requires golang 1.8, so unless we vendor older versions building on go 1.7 will fail.
Update build matrix
This is no longer supported, because fuse.AllowRoot() was removed: bazil/fuse@e0b8970
This is needed to build against the latest version of basil.org/fuse.
…ption Remove allow_root mount option
This fixes the problem where --root-node-id was broken for non-team drives and also should allow mounting a sub.directory of a team drive by specifying both --drive-id and --root-node-id.
This should fix the unexpected change records without a file resource. Additionally we request to include the file resource for removals, which could be another reason of missing file resource in changes.
Team Drive Fixes
This option was removed in #340.
Use Go Modules
Put cache.bolt in config directory by default
Add support for --acknowledge-abuse flag to allow users to continue using their files
We didn't raise the index version when swapping the chunk fields, so this swaps the field by guessing the existing field order. Should be removed once code is table.
and skip storing pageToken if it hasn't changed.
This avoids enconding/decodind and unneeded copies, but it makes the chunk cache file endianess dependent. To detect endianess difference the PD magic bytes are not stores as uint16 so the flip to DP if endianess has changes and the cache becomes invalid.
Note that resizing is currently not supported, since we lack information to discover the last position of the journal.
Instead of creating a separate mmap region for each chunk this maps one or multiple regions at the maximum allowed size and creates the chunks as slices from these mappings. This should in theory also work with 32-Bit Linux systems and LFS support, were a single mmap region will be limited to about 2GB, so multiple mappings are used if the chunk file is bigger than 2GB.
This isn't needed, since we're at EOF anyways, so nothing after the toc needs to be aligned and the size itself doesn't have to be aligned.
This should ensure consistent downloads, since it was previously possible that the cached MD5 sum of a recently changed object was used as the chunk cache / request id for the download. By also using the cached revision id, this should no longer be a problem.
This ensures that drive objects have stable node hashes, enables keeping kernel buffer caches across file opens and invalidates the buffer cache when changes are detected. Also added code to ensure the root node is a folder.
Since both the persistent cache to the chunk-file and the non-persistent cache use mmap, the naming was confusing.
MMap based chunk cache and disk based caching
and remove now unsupported darwin/386 target.
Since argConfigPath is only updated after parsing the flags, these paths always used ~/.plexdrive even if a different config directory was set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring develop up to date with Master.