Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: Define port for NodePort #100

Merged
merged 2 commits into from Feb 5, 2024
Merged

Conversation

alphayax
Copy link
Contributor

Initial problem

When installing the chart on my microk8s cluster, I use NodePort to make Plex accessible from internet. But, the port is randomly defined, and can change at any time.

This PR Solution

Add the ability to define the node port to use when service is NodePort. Default is 32400.

  • When service = NodePort, the nodePort will automatically be 32400 by default.
  • If user want to override and define is own node port, he can define the .Value.service.nodePort value to whatever he want

@alphayax alphayax requested a review from a team as a code owner January 27, 2024 09:38
Copy link
Member

@cilindrox cilindrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

charts/plex-media-server/values.yaml Outdated Show resolved Hide resolved
@cilindrox cilindrox self-assigned this Feb 5, 2024
@cilindrox
Copy link
Member

Thanks @alphayax - could you bump the version to a minor (0.2.0) so we can release this?

@cilindrox cilindrox merged commit c7dd9df into plexinc:master Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants