Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve whitespace #168

Merged
merged 5 commits into from Jun 2, 2021
Merged

Preserve whitespace #168

merged 5 commits into from Jun 2, 2021

Conversation

jpreese
Copy link
Collaborator

@jpreese jpreese commented Jun 2, 2021

#159

I was a bad noodle and combined some linting/formatting with the change itself, but have added some discussion comments below highlighting the critical pieces of the change itself.

Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good change! A few items to consider. Only the first is a blocker.

internal/commands/create.go Outdated Show resolved Hide resolved
internal/commands/create.go Show resolved Hide resolved
internal/rego/rego.go Outdated Show resolved Hide resolved
internal/rego/rego.go Outdated Show resolved Hide resolved
@jpreese
Copy link
Collaborator Author

jpreese commented Jun 2, 2021

@jalseth all review comments should be addressed

Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! shipit 🚢

@jpreese
Copy link
Collaborator Author

jpreese commented Jun 2, 2021

LGTM! shipit 🚢

✈️ ✈️ ✈️

@jpreese jpreese merged commit 1d3eddb into main Jun 2, 2021
@jalseth jalseth deleted the preserve-whitespace branch June 2, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants