Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new UI #130

Merged
merged 24 commits into from
Jul 19, 2023
Merged

new UI #130

merged 24 commits into from
Jul 19, 2023

Conversation

PatrikMatiasko
Copy link
Contributor

@PatrikMatiasko PatrikMatiasko commented Jul 8, 2023

Revamp UI to align with the latest design.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as outdated.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@PatrikMatiasko
Copy link
Contributor Author

PatrikMatiasko commented Jul 17, 2023

> 3 co

We have a condition for display in the tree. Row is visible, whew: canBeResourceEdited(endpointInformations) || isOwned
from the past. Can I change it?

export const canBeResourceEdited = (endpoints?: { endpoint: string }[]) => endpoints && endpoints.some( (e: { endpoint: string }) => e.endpoint.indexOf('coap://') > -1 || e.endpoint.indexOf('coap+tcp://') > -1 )

UPDATE: I have solution, you can check with new commit

@jkralik

This comment was marked as resolved.

@jkralik

This comment was marked as resolved.

@jkralik
Copy link
Member

jkralik commented Jul 18, 2023

> 3 co

We have a condition for display in the tree. Row is visible, whew: canBeResourceEdited(endpointInformations) || isOwned from the past. Can I change it?

export const canBeResourceEdited = (endpoints?: { endpoint: string }[]) => endpoints && endpoints.some( (e: { endpoint: string }) => e.endpoint.indexOf('coap://') > -1 || e.endpoint.indexOf('coap+tcp://') > -1 )

UPDATE: I have solution, you can check with new commit

Yes it works :)

When I look to function canBeResourceEdited is see it in two places:

web/src/containers/Devices/utils.ts:36
web/packages/shared-ui/src/stories/Table/TreeTable.stories.jsx:27

pls could you deduplicate it ?

@PatrikMatiasko
Copy link
Contributor Author

> 3 co
We have a condition for display in the tree. Row is visible, whew: canBeResourceEdited(endpointInformations) || isOwned from the past. Can I change it?
export const canBeResourceEdited = (endpoints?: { endpoint: string }[]) => endpoints && endpoints.some( (e: { endpoint: string }) => e.endpoint.indexOf('coap://') > -1 || e.endpoint.indexOf('coap+tcp://') > -1 )
UPDATE: I have solution, you can check with new commit

Yes it works :)

When I look to function canBeResourceEdited is see it in two places:

web/src/containers/Devices/utils.ts:36 web/packages/shared-ui/src/stories/Table/TreeTable.stories.jsx:27

pls could you deduplicate it ?

It should work as it is. :)

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jkralik jkralik merged commit 4731477 into main Jul 19, 2023
8 of 9 checks passed
@jkralik jkralik deleted the pm/new-design branch July 19, 2023 15:26
@jkralik jkralik changed the title Pm/new design new UI Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants