Feat/peer certificates #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will, for example, allow the server to get the client certificate (chain) in case of DTLS. The certificates can be accessed as `req.PeerCertificates` where `req` is of type `req *coap.Request`.
PeerCertificates are accessed through the ClientCommander and is only implemented for DTLS, the other sessions return `nil`.
jdbruijn
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
This looks good to me. Thanks so much for creating these tests. Just looking at them I couldn't have come up with it, but it teaches me a lot just going through the test. Thanks for helping me learn!
For what its worth: I've verified that this indeeds tests what I had in mind (whether PeerCertificates returns a value).
|
For completeness: this closes #103. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.