observation: handle state when the resource observation is not supported #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkralik
force-pushed
the
jkralik/fix/observationNotSupported
branch
8 times, most recently
from
44b7300
to
5efd3ac
Compare
when the client receives a notification without observing option, it means that the resource doesn't support the observation. - added a call to check if the observation is canceled `obs.Canceled` - automatically clean up observation, so users don't need to call `obs.Cancel`
jkralik
force-pushed
the
jkralik/fix/observationNotSupported
branch
from
5efd3ac
to
ceef619
Compare
|
SonarCloud Quality Gate failed.
|
Danielius1922
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the client receives a notification without observing option, it
means that the resource doesn't support the observation.
obs.Canceledobs.Cancel