Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizations of caches and network stack #260

Merged
merged 16 commits into from
Dec 1, 2021

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Nov 26, 2021

  • net: remove set deadlines - goroutines are not wakeup for timeouts
  • introduce better cache for expirations

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #260 (19f488d) into master (d32a1fa) will increase coverage by 3.29%.
The diff coverage is 78.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   60.41%   63.71%   +3.29%     
==========================================
  Files          61       78      +17     
  Lines        4916     5627     +711     
==========================================
+ Hits         2970     3585     +615     
- Misses       1598     1683      +85     
- Partials      348      359      +11     
Impacted Files Coverage Δ
examples/mcast/client/main.go 0.00% <0.00%> (ø)
net/monitor/inactivity/keepalive.go 91.66% <ø> (ø)
net/options.go 100.00% <ø> (+65.95%) ⬆️
tcp/client.go 4.47% <0.00%> (ø)
udp/client/client.go 10.44% <22.22%> (ø)
tcp/options.go 43.65% <30.00%> (+3.47%) ⬆️
dtls/options.go 46.95% <46.15%> (+8.06%) ⬆️
udp/options.go 58.26% <46.15%> (+18.63%) ⬆️
net/connUDP.go 61.84% <58.33%> (+11.11%) ⬆️
net/dtlslistener.go 70.00% <65.00%> (+70.00%) ⬆️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32a1fa...19f488d. Read the comment docs.

@jkralik jkralik force-pushed the jkralik/feature/refactoreNetworks branch from f4a6373 to 1115429 Compare November 26, 2021 17:27
@jkralik jkralik force-pushed the jkralik/feature/refactoreNetworks branch from ce952f4 to 103bcb0 Compare November 29, 2021 14:57
@jkralik jkralik force-pushed the jkralik/feature/refactoreNetworks branch 2 times, most recently from 6e448a9 to 5e05c9e Compare November 29, 2021 16:00
@jkralik jkralik force-pushed the jkralik/feature/refactoreNetworks branch from 5e05c9e to febf18a Compare November 29, 2021 16:05
@jkralik jkralik linked an issue Nov 29, 2021 that may be closed by this pull request
@jkralik jkralik changed the title optimizations optimizations of caches and network stack Nov 29, 2021
@jkralik jkralik marked this pull request as ready for review November 29, 2021 16:57
@jkralik jkralik force-pushed the jkralik/feature/refactoreNetworks branch from 19f488d to de92ffb Compare November 29, 2021 17:02
net/connUDP.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.5% 84.5% Coverage
11.9% 11.9% Duplication

@jkralik jkralik merged commit dcdffa0 into master Dec 1, 2021
@jkralik jkralik deleted the jkralik/feature/refactoreNetworks branch December 1, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove multiple cache-maps
3 participants