efficient struct packing #264
Conversation
jkralik
force-pushed
the
jkralik/fix/optimizeMemoryUsage
branch
from
3121db1
to
ce997d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
- Coverage 63.79% 63.79% -0.01%
==========================================
Files 79 79
Lines 5638 5640 +2
==========================================
+ Hits 3597 3598 +1
Misses 1683 1683
- Partials 358 359 +1
Continue to review full report at Codecov.
|
|
I still get one report of suboptimal struct size: |
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -11,6 +12,10 @@ func (t Token) String() string { | |||
| return hex.EncodeToString(t) | |||
| } | |||
|
|
|||
| func (t Token) Hash() uint64 { | |||
There was a problem hiding this comment.
We could cache the value if the function is used often, eg:
type Token struct {
data []byte
hash uint64
}
Calculate the value on first use, save it and then use only cached value.
There was a problem hiding this comment.
Hash is a very cheap operation so was can leave it as is otherwise we need to introduce a constructor which fills the value.
No description provided.