Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues reported by errcheck #269

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Fix issues reported by errcheck #269

merged 5 commits into from
Jan 12, 2022

Conversation

Danielius1922
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021 •
edited

Codecov Report

Merging #269 (02803db) into master (cc423e1) will increase coverage by 0.02%.
The diff coverage is 71.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   63.76%   63.79%   +0.02%     
==========================================
  Files          75       76       +1     
  Lines        5636     5709      +73     
==========================================
+ Hits         3594     3642      +48     
- Misses       1679     1689      +10     
- Partials      363      378      +15
Impacted Files Coverage Δ
tcp/session.go 69.36% <11.11%> (-2.39%) ⬇️
mux/router.go 50.60% <38.46%> (-4.53%) ⬇️
tcp/clientconn.go 68.59% <64.51%> (-0.82%) ⬇️
tcp/container.go 93.54% <75.00%> (ø)
tcp/server.go 81.13% <77.77%> (-0.30%) ⬇️
dtls/client.go 75.86% <84.00%> (+0.63%) ⬆️
dtls/server.go 83.81% <86.11%> (+1.03%) ⬆️
net/error_unix.go 100.00% <100.00%> (ø)
tcp/clientobserve.go 70.87% <100.00%> (+0.28%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc423e1...02803db. Read the comment docs.

@Danielius1922 Danielius1922 force-pushed the adam/feature/errorCheck branch 6 times, most recently from ebe37ae to a4bc27f Compare December 17, 2021 16:27
@Danielius1922 Danielius1922 force-pushed the adam/feature/staticCheck branch 2 times, most recently from 02c9652 to 8299734 Compare January 8, 2022 16:46
Base automatically changed from adam/feature/staticCheck to master January 8, 2022 17:07
@Danielius1922 Danielius1922 force-pushed the adam/feature/errorCheck branch 3 times, most recently from 569c975 to 67300d5 Compare January 10, 2022 11:35
@Danielius1922 Danielius1922 marked this pull request as draft January 10, 2022 13:58
@Danielius1922 Danielius1922 force-pushed the adam/feature/errorCheck branch 7 times, most recently from 02803db to f442f43 Compare January 11, 2022 09:19
@Danielius1922 Danielius1922 marked this pull request as ready for review January 11, 2022 09:28
@Danielius1922 Danielius1922 force-pushed the adam/feature/errorCheck branch 2 times, most recently from 2ac9ac2 to 6106d7e Compare January 11, 2022 15:22
jkralik
jkralik reviewed Jan 11, 2022
View reviewed changes
tcp/clientobserve.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.3% 70.3% Coverage
3.5% 3.5% Duplication

@Danielius1922 Danielius1922 merged commit fb5b479 into master Jan 12, 2022
@Danielius1922 Danielius1922 deleted the adam/feature/errorCheck branch January 12, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkralik jkralik jkralik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Danielius1922 @codecov-commenter @jkralik