Improve gocyclo from 43 to 24 for blockwise processReceivedMessage #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net/blockwise/blockwise.go
Outdated
| msgGuard = cachedReceivedMessageGuard.(*messageGuard) | ||
| err := msgGuard.Acquire(msgGuard.Context(), 1) | ||
| if err != nil { | ||
| return nil, 0, fmt.Errorf("handlerReceivedCache: cannot lock message: %v", err) |
There was a problem hiding this comment.
the label in fmt.Errorf handlerReceivedCache doesn't correspond to the function name.
EDIT: same for additional two places in this function, please fix that and we can merge it.
There was a problem hiding this comment.
done.
nits: *sended* -> *sent* to be changed in logs, error messages, function names and var names across this library.
There was a problem hiding this comment.
Yeah, I've run misspell over the code, but there's still plenty of spelling mistakes left. Perhaps there's some other tool I can integrate to check the code. Anyway, feel free to fix a mistake when you see it.
Danielius1922
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- handling observe response
-- fetching the received message from the cache
-- fetching the payload from the received message
-- sending the response
could be better if we can bringdown the gocyclo index to 15. currently it is at 24.