Fix issues reported by errcheck #285

Danielius1922 · 2022-01-12T17:04:52Z

No description provided.

sonarcloud · 2022-01-12T17:22:23Z

Please retry analysis of this Pull-Request directly on SonarCloud.

Danielius1922 · 2022-01-13T08:42:59Z

server.go

 		s := udp.NewServer(udp.WithMux(handler))
+		defer func() {
+			if err := l.Close(); err != nil {


Wasn't sure how to handle this, so there are three suggestions in this file

add public Error method to tcp/udp.Server that handles errors

use log.Printf

ignore it

@jkralik what do you think, which way is the best?

you can handle this error at line 32. If s.Serve returns nil then you use error from l.Close

I guess that's alright, we can ignore the Close error if the Serve call fails.

Danielius1922 · 2022-01-13T08:45:11Z

net/monitor/inactivity/inactivitymonitor.go

@@ -36,8 +35,8 @@ func (m *inactivityMonitor) LastActivity() time.Time {
 	return time.Time{}
 }

-func CloseClientConn(cc ClientConn) {
-	cc.Close()
+func CloseClientConn(cc ClientConn) error {


API change, but adding error output shouldn't break most code (only cases I can think of is assigning to function pointer with previous signature or adhering to interface).

This is concrete default implemenetation. So for default, we can ignore the error.

Actually, func CloseClientConn is not used anywhere. Do we need it at all? The caller can call Close on CloseClientConn directly without this wrapper.

udp/message/getmid.go

codecov-commenter · 2022-01-13T12:30:32Z

Codecov Report

Merging #285 (4fd49ff) into master (fb5b479) will decrease coverage by 0.20%.
The diff coverage is 54.33%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   63.82%   63.61%   -0.21%     
==========================================
  Files          76       76              
  Lines        5708     5755      +47     
==========================================
+ Hits         3643     3661      +18     
- Misses       1688     1705      +17     
- Partials      377      389      +12

Impacted Files	Coverage Δ
net/blockwise/blockwise.go	`67.99% <0.00%> (-0.14%)`	⬇️
net/connUDP.go	`60.69% <0.00%> (-0.94%)`	⬇️
net/monitor/inactivity/inactivitymonitor.go	`78.26% <0.00%> (ø)`
server.go	`0.00% <0.00%> (ø)`
tcp/server.go	`80.12% <0.00%> (-1.01%)`	⬇️
udp/server.go	`81.50% <54.54%> (-2.88%)`	⬇️
udp/client/clientconn.go	`73.18% <60.00%> (-0.53%)`	⬇️
udp/message/getmid.go	`80.00% <60.00%> (-20.00%)`	⬇️
udp/client/container.go	`93.54% <75.00%> (ø)`
udp/client.go	`84.87% <79.16%> (+0.05%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5b479...4fd49ff. Read the comment docs.