Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for route params #295

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

Danielius1922
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #295 (cd1f55c) into master (49cae1c) will increase coverage by 0.26%.
The diff coverage is 78.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   63.98%   64.25%   +0.26%     
==========================================
  Files          76       77       +1     
  Lines        5884     5970      +86     
==========================================
+ Hits         3765     3836      +71     
- Misses       1722     1726       +4     
- Partials      397      408      +11     
Impacted Files Coverage Δ
mux/regexp.go 77.46% <77.46%> (ø)
mux/router.go 63.26% <77.77%> (+12.66%) ⬆️
message/options.go 71.26% <100.00%> (-0.17%) ⬇️
tcp/optionmux.go 88.23% <100.00%> (+0.73%) ⬆️
udp/client/mux.go 88.88% <100.00%> (+0.65%) ⬆️
net/conn.go 82.81% <0.00%> (-3.13%) ⬇️
udp/client/clientobserve.go 71.71% <0.00%> (-1.02%) ⬇️
tcp/clientobserve.go 70.58% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49cae1c...cd1f55c. Read the comment docs.

@Danielius1922 Danielius1922 force-pushed the DavidMarquezF/feature/route-params branch from cd1f55c to 7058aa4 Compare January 24, 2022 14:14
@Danielius1922 Danielius1922 changed the title David marquez f/feature/route params Add support for route params Jan 24, 2022
@Danielius1922 Danielius1922 marked this pull request as ready for review January 24, 2022 14:16
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@Danielius1922 Danielius1922 merged commit c3e8d8d into master Jan 25, 2022
@Danielius1922 Danielius1922 deleted the DavidMarquezF/feature/route-params branch January 25, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants