Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message: add tests to increase code coverage #296

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

Danielius1922
Copy link
Member

No description provided.

Update SetPath interface to return error in case the input
path has invalid form.
Add MustSetPath function that retains original interface
and panics on error.
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #296 (3e55b41) into master (c3e8d8d) will increase coverage by 4.87%.
The diff coverage is 83.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   64.30%   69.17%   +4.87%     
==========================================
  Files          77       66      -11     
  Lines        5970     5509     -461     
==========================================
- Hits         3839     3811      -28     
+ Misses       1725     1309     -416     
+ Partials      406      389      -17     
Impacted Files Coverage Δ
tcp/clientconn.go 68.68% <0.00%> (-0.86%) ⬇️
udp/client/clientconn.go 71.56% <0.00%> (-1.08%) ⬇️
message/pool/message.go 61.83% <63.63%> (+1.83%) ⬆️
test/net/uri.go 93.93% <93.93%> (ø)
message/options.go 75.00% <100.00%> (+3.73%) ⬆️
tcp/options.go 39.28% <0.00%> (-4.37%) ⬇️
udp/client/mutexmap.go 85.71% <0.00%> (-1.79%) ⬇️
examples/dtls/pki/server/main.go
examples/observe/server/main.go
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e8d8d...3e55b41. Read the comment docs.

@Danielius1922 Danielius1922 marked this pull request as ready for review January 26, 2022 14:13
Add GetPathBufferSize helper function to calculate size
needed by buffer to store given path in URI-Path options.
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.1% 84.1% Coverage
2.4% 2.4% Duplication

@Danielius1922 Danielius1922 merged commit 20ce904 into master Jan 29, 2022
@Danielius1922 Danielius1922 deleted the adam/feature/increase-coverage branch January 29, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants