-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
message: add tests to increase code coverage #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielius1922
commented
Jan 25, 2022
Update SetPath interface to return error in case the input path has invalid form. Add MustSetPath function that retains original interface and panics on error.
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 64.30% 69.17% +4.87%
==========================================
Files 77 66 -11
Lines 5970 5509 -461
==========================================
- Hits 3839 3811 -28
+ Misses 1725 1309 -416
+ Partials 406 389 -17
Continue to review full report at Codecov.
|
Danielius1922
commented
Jan 26, 2022
jkralik
approved these changes
Jan 29, 2022
Danielius1922
force-pushed
the
adam/feature/increase-coverage
branch
from
January 29, 2022 13:49
86af823
to
9e03f8e
Compare
Add GetPathBufferSize helper function to calculate size needed by buffer to store given path in URI-Path options.
Danielius1922
force-pushed
the
adam/feature/increase-coverage
branch
from
January 29, 2022 14:26
9e03f8e
to
3e55b41
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.