Fixes for SonarCloud #299
Merged
Fixes for SonarCloud #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 69.02% 69.34% +0.32%
==========================================
Files 67 67
Lines 5592 5605 +13
==========================================
+ Hits 3860 3887 +27
+ Misses 1327 1311 -16
- Partials 405 407 +2
Continue to review full report at Codecov.
|
Danielius1922
commented
Jan 29, 2022
Danielius1922
commented
Jan 30, 2022
Danielius1922
force-pushed
the
adam/feature/increase-coverage-2
branch
2 times, most recently
from
bfba4b1
to
96c9e72
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Refactor dtls.Serve and tls.Serve to lower function complexity.
Refactor tcp.processBuffer to lower function complexity.
Danielius1922
force-pushed
the
adam/feature/increase-coverage-2
branch
2 times, most recently
from
6908f2b
to
a58b91d
Compare
Modify the interface bacause ETag option is repeatable: - AddETag allows to add value for the option without replacing the previously existing ones - ETags writes all values for the option to output array
Danielius1922
force-pushed
the
adam/feature/increase-coverage-2
branch
from
a58b91d
to
f27085d
Compare
jkralik
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.