Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtls/tcp/udp: ignore close error during closing connection #303

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Feb 1, 2022

No description provided.

tcp/clientconn.go Outdated Show resolved Hide resolved
net/error.go Outdated Show resolved Hide resolved
tcp/clientconn.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #303 (51c8881) into master (1f4c6bb) will increase coverage by 4.19%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   64.33%   68.52%   +4.19%     
==========================================
  Files          77       66      -11     
  Lines        5970     5459     -511     
==========================================
- Hits         3841     3741     -100     
+ Misses       1723     1324     -399     
+ Partials      406      394      -12     
Impacted Files Coverage Δ
tcp/clientconn.go 69.14% <60.00%> (-0.39%) ⬇️
net/error.go 66.66% <66.66%> (ø)
dtls/client.go 75.86% <100.00%> (ø)
udp/client.go 84.69% <100.00%> (-0.19%) ⬇️
udp/client/clientconn.go 71.87% <100.00%> (-0.77%) ⬇️
tcp/options.go 39.28% <0.00%> (-4.37%) ⬇️
udp/client/mutexmap.go 85.71% <0.00%> (-1.79%) ⬇️
tcp/clientobserve.go 70.58% <0.00%> (-0.99%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4c6bb...51c8881. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.2% 88.2% Coverage
11.1% 11.1% Duplication

@jkralik jkralik merged commit d741687 into master Feb 2, 2022
@jkralik jkralik deleted the jkralik/fix/ignoreCloseError branch February 2, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants