Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udp: allows to create ClientConn at server #316

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Mar 29, 2022

Fixes #315

@codecov-commenter
Copy link

Codecov Report

Merging #316 (4e9474f) into master (96978f2) will decrease coverage by 0.13%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   69.28%   69.15%   -0.14%     
==========================================
  Files          67       67              
  Lines        5571     5583      +12     
==========================================
+ Hits         3860     3861       +1     
- Misses       1312     1320       +8     
- Partials      399      402       +3     
Impacted Files Coverage Δ
udp/server.go 83.09% <78.94%> (-0.99%) ⬇️
net/conn.go 82.81% <0.00%> (-3.13%) ⬇️
udp/client/clientconn.go 70.81% <0.00%> (-0.96%) ⬇️
tcp/clientobserve.go 66.38% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96978f2...4e9474f. Read the comment docs.

Copy link

@ihidchaos ihidchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge it to the master branch?

udp/server.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
0.0% 0.0% Duplication

@jkralik jkralik merged commit 0f32afd into master Mar 31, 2022
@jkralik jkralik deleted the jkralik/feature/createClientConnAtServer branch March 31, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to reuse the udp socket as both Server and Client
4 participants