Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message: Implement Options.LocationPath() & Options.SetLocationPath() #327

Merged
merged 1 commit into from
May 12, 2022
Merged

message: Implement Options.LocationPath() & Options.SetLocationPath() #327

merged 1 commit into from
May 12, 2022

Conversation

maribu
Copy link
Contributor

@maribu maribu commented May 11, 2022

As trivial as the title says

@jkralik
Copy link
Member

jkralik commented May 11, 2022

Please, could you add a test? thx

@maribu
Copy link
Contributor Author

maribu commented May 11, 2022

Done. Shall I squash?

@jkralik
Copy link
Member

jkralik commented May 11, 2022

Done. Shall I squash?

Yes. Thx

@Danielius1922
Copy link
Member

Interesting, we don't have a SonarCloud or codecov reports, I guess the workflows are not setup properly for forked repositories. Note taken.

@maribu maribu changed the title message: Implement Options.LocationPath() message: Implement Options.LocationPath() & Options.SetLocationPath() May 12, 2022
@Danielius1922 Danielius1922 merged commit 3660ff2 into plgd-dev:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants