Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/udp: add option WithMulticastInterfaceError #332

Merged
merged 1 commit into from
May 24, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented May 24, 2022

No description provided.

@jkralik jkralik force-pushed the jkralik/feature/allowToSetMulticastInterfaceError branch from 61280ff to c2b4ec1 Compare May 24, 2022 06:54
@jkralik jkralik changed the title net/udp: add option WithMulticastInterfaceError: net/udp: add option WithMulticastInterfaceError May 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #332 (c2b4ec1) into master (6cb0f09) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   69.10%   68.89%   -0.22%     
==========================================
  Files          67       67              
  Lines        5600     5562      -38     
==========================================
- Hits         3870     3832      -38     
- Misses       1325     1327       +2     
+ Partials      405      403       -2     
Impacted Files Coverage Δ
net/connUDP.go 62.34% <0.00%> (-1.56%) ⬇️
net/options.go 47.05% <0.00%> (-6.28%) ⬇️
tcp/clientobserve.go 66.38% <0.00%> (-0.85%) ⬇️
udp/client/clientconn.go 71.64% <0.00%> (-0.13%) ⬇️
udp/client/client.go 10.44% <0.00%> (-0.08%) ⬇️
udp/optionmux.go 100.00% <0.00%> (ø)
udp/message/message.go 67.18% <0.00%> (+0.52%) ⬆️
tcp/message/message.go 68.54% <0.00%> (+0.52%) ⬆️
tcp/optionmux.go 88.23% <0.00%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb0f09...c2b4ec1. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@jkralik jkralik merged commit e412791 into master May 24, 2022
@jkralik jkralik deleted the jkralik/feature/allowToSetMulticastInterfaceError branch May 24, 2022 07:00
@HRogge
Copy link
Collaborator

HRogge commented May 24, 2022

This is a really nice way to "rescue" the errors from the inner loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants