Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udp: don't return closed connection for server.NewClientConn() #344

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jun 20, 2022

No description provided.

@jkralik jkralik force-pushed the jkralik/fix/udpServerNewClientConn branch from ef1fe8b to 1e31bdd Compare June 20, 2022 16:45
udp/server.go Outdated Show resolved Hide resolved
udp/server.go Outdated Show resolved Hide resolved
@jkralik jkralik force-pushed the jkralik/fix/udpServerNewClientConn branch from 1e31bdd to 824247f Compare June 20, 2022 17:04
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #344 (9960dac) into master (2600f7e) will decrease coverage by 0.04%.
The diff coverage is 83.87%.

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   69.50%   69.46%   -0.05%     
==========================================
  Files          67       67              
  Lines        5651     5669      +18     
==========================================
+ Hits         3928     3938      +10     
- Misses       1315     1322       +7     
- Partials      408      409       +1     
Impacted Files Coverage Δ
udp/server.go 82.22% <72.22%> (-0.80%) ⬇️
net/monitor/inactivity/keepalive.go 92.59% <100.00%> (+0.92%) ⬆️
udp/client/clientconn.go 71.90% <100.00%> (+0.13%) ⬆️
dtls/server.go 84.00% <0.00%> (-1.72%) ⬇️
net/conn.go 84.37% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2600f7e...9960dac. Read the comment docs.

@jkralik jkralik force-pushed the jkralik/fix/udpServerNewClientConn branch 2 times, most recently from b7d351d to 9960dac Compare June 21, 2022 06:54
Copy link
Member

@Danielius1922 Danielius1922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some issue with tests right now.

@Danielius1922
Copy link
Member

( And maybe you can some additional test to increase coverage ;) )

@jkralik jkralik force-pushed the jkralik/fix/udpServerNewClientConn branch from 9960dac to 673fa29 Compare June 21, 2022 08:23
@jkralik
Copy link
Member Author

jkralik commented Jun 21, 2022

( And maybe you can some additional test to increase coverage ;) )

Fixed

@jkralik jkralik merged commit 8a6df8e into master Jun 21, 2022
@jkralik jkralik deleted the jkralik/fix/udpServerNewClientConn branch June 21, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants