Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pkg/cache, pkg/sync/map to use generics #352

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Danielius1922
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #352 (05c45d2) into master (0375d80) will increase coverage by 0.65%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   69.67%   70.32%   +0.65%     
==========================================
  Files          67       68       +1     
  Lines        5675     5780     +105     
==========================================
+ Hits         3954     4065     +111     
+ Misses       1314     1307       -7     
- Partials      407      408       +1     
Impacted Files Coverage Δ
message/status/status.go 0.00% <ø> (ø)
udp/client/clientconn.go 71.90% <ø> (ø)
udp/server.go 82.22% <ø> (-1.78%) ⬇️
dtls/client.go 78.37% <20.00%> (+2.72%) ⬆️
tcp/clientconn.go 69.17% <30.00%> (+0.97%) ⬆️
dtls/server.go 84.00% <100.00%> (ø)
pkg/sync/map.go 100.00% <100.00%> (ø)
tcp/server.go 81.28% <100.00%> (ø)
udp/client.go 84.21% <100.00%> (-0.54%) ⬇️
udp/client/clientobserve.go 67.24% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0375d80...05c45d2. Read the comment docs.

@Danielius1922 Danielius1922 force-pushed the adam/feature/golansci-upd-4 branch 3 times, most recently from cc52725 to 30e36a5 Compare June 26, 2022 09:36
pkg/sync/map.go Outdated Show resolved Hide resolved
pkg/sync/map.go Outdated Show resolved Hide resolved
pkg/sync/map.go Outdated Show resolved Hide resolved
@Danielius1922 Danielius1922 force-pushed the adam/feature/golansci-upd-4 branch 2 times, most recently from 05c45d2 to 41304d6 Compare July 1, 2022 16:23
@jkralik jkralik marked this pull request as ready for review July 4, 2022 09:13
New synchronized map using generics to be used instead of the map
from github.com/plgd-dev/kit/v2/sync which uses interface{}.
@Danielius1922 Danielius1922 merged commit 568a42a into master Jul 6, 2022
@Danielius1922 Danielius1922 deleted the adam/feature/golansci-upd-4 branch July 6, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants