Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge responseWriters #359

Merged
merged 1 commit into from
Jul 20, 2022
Merged

merge responseWriters #359

merged 1 commit into from
Jul 20, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jul 18, 2022

No description provided.

@jkralik jkralik force-pushed the jkralik/feature/mergeResponseWriter branch from 045a33c to e2a082f Compare July 19, 2022 05:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #359 (9a08c53) into jkralik/feature/removeHandlerContainer (f77d107) will increase coverage by 0.13%.
The diff coverage is 85.18%.

@@                            Coverage Diff                             @@
##           jkralik/feature/removeHandlerContainer     #359      +/-   ##
==========================================================================
+ Coverage                                   70.23%   70.37%   +0.13%     
==========================================================================
  Files                                          65       64       -1     
  Lines                                        5496     5451      -45     
==========================================================================
- Hits                                         3860     3836      -24     
+ Misses                                       1245     1229      -16     
+ Partials                                      391      386       -5     
Impacted Files Coverage Δ
dtls/client.go 76.31% <0.00%> (ø)
dtls/server.go 84.00% <0.00%> (ø)
udp/server.go 84.00% <50.00%> (+1.77%) ⬆️
tcp/session.go 70.77% <66.66%> (ø)
net/responsewriter/responseWriter.go 65.71% <88.88%> (ø)
udp/client/clientconn.go 72.00% <90.47%> (-0.35%) ⬇️
tcp/clientconn.go 67.82% <100.00%> (ø)
tcp/clientobserve.go 66.66% <100.00%> (+0.83%) ⬆️
tcp/optionmux.go 100.00% <100.00%> (ø)
tcp/server.go 81.28% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77d107...9a08c53. Read the comment docs.

@jkralik jkralik force-pushed the jkralik/feature/mergeResponseWriter branch from e2a082f to 284cc44 Compare July 19, 2022 06:04
@jkralik jkralik force-pushed the jkralik/feature/mergeResponseWriter branch from 9a08c53 to 284cc44 Compare July 20, 2022 05:59
@jkralik jkralik force-pushed the jkralik/feature/removeHandlerContainer branch from f77d107 to 1df4040 Compare July 20, 2022 11:58
Base automatically changed from jkralik/feature/removeHandlerContainer to v3 July 20, 2022 12:15
@jkralik jkralik force-pushed the jkralik/feature/mergeResponseWriter branch from 284cc44 to 4dfd18b Compare July 20, 2022 12:16
@jkralik jkralik merged commit 0befdba into v3 Jul 20, 2022
@jkralik jkralik deleted the jkralik/feature/mergeResponseWriter branch July 20, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants