Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge observation handler #360

Merged
merged 7 commits into from
Jul 21, 2022
Merged

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jul 19, 2022

No description provided.

@jkralik jkralik force-pushed the jkralik/feature/mergeObservationHandler branch 3 times, most recently from 6484592 to f20fa9d Compare July 19, 2022 10:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #360 (6c88849) into v3 (0befdba) will increase coverage by 1.00%.
The diff coverage is 75.07%.

@@            Coverage Diff             @@
##               v3     #360      +/-   ##
==========================================
+ Coverage   70.40%   71.41%   +1.00%     
==========================================
  Files          64       61       -3     
  Lines        5457     5261     -196     
==========================================
- Hits         3842     3757      -85     
+ Misses       1234     1129     -105     
+ Partials      381      375       -6     
Impacted Files Coverage Δ
mux/router.go 63.63% <ø> (ø)
net/responsewriter/responseWriter.go 76.92% <ø> (+11.20%) ⬆️
net/blockwise/blockwise.go 68.67% <50.00%> (+0.18%) ⬆️
tcp/session.go 70.92% <64.28%> (+0.14%) ⬆️
udp/client/clientconn.go 70.58% <68.96%> (-1.76%) ⬇️
net/observation/handler.go 69.64% <69.64%> (ø)
tcp/clientconn.go 70.62% <74.24%> (+2.80%) ⬆️
mux/muxResponseWriter.go 75.00% <75.00%> (ø)
udp/client.go 83.87% <83.33%> (-2.80%) ⬇️
udp/server.go 83.08% <83.33%> (+0.86%) ⬆️
... and 14 more

@jkralik jkralik force-pushed the jkralik/feature/mergeObservationHandler branch from 333ebec to 19ed5fe Compare July 19, 2022 15:00
@jkralik jkralik force-pushed the jkralik/feature/mergeResponseWriter branch from 9a08c53 to 284cc44 Compare July 20, 2022 05:59
@jkralik jkralik force-pushed the jkralik/feature/mergeObservationHandler branch from 19ed5fe to 5d87518 Compare July 20, 2022 06:01
@jkralik jkralik force-pushed the jkralik/feature/mergeResponseWriter branch from 284cc44 to 4dfd18b Compare July 20, 2022 12:16
Base automatically changed from jkralik/feature/mergeResponseWriter to v3 July 20, 2022 12:21
@jkralik jkralik force-pushed the jkralik/feature/mergeObservationHandler branch from 0e66507 to 999214c Compare July 20, 2022 12:23
@jkralik jkralik changed the title Jkralik/feature/merge observation handler merge observation handler Jul 20, 2022
@jkralik jkralik force-pushed the jkralik/feature/mergeObservationHandler branch from 252170a to 6c88849 Compare July 21, 2022 10:14
@jkralik jkralik merged commit 3ce2dc3 into v3 Jul 21, 2022
@jkralik jkralik deleted the jkralik/feature/mergeObservationHandler branch July 21, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants