Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge common client commands #364

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jul 20, 2022

No description provided.

@jkralik jkralik force-pushed the jkralik/feature/mergeCommonClientConnCommands branch 3 times, most recently from 56f1092 to bbe5746 Compare July 20, 2022 12:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #364 (7f9d8ff) into jkralik/feature/cleanupBW (142cd78) will decrease coverage by 0.33%.
The diff coverage is 58.29%.

@@                      Coverage Diff                      @@
##           jkralik/feature/cleanupBW     #364      +/-   ##
=============================================================
- Coverage                      71.46%   71.13%   -0.34%     
=============================================================
  Files                             61       62       +1     
  Lines                           5201     5182      -19     
=============================================================
- Hits                            3717     3686      -31     
- Misses                          1112     1122      +10     
- Partials                         372      374       +2     
Impacted Files Coverage Δ
net/observation/handler.go 64.80% <0.00%> (-6.51%) ⬇️
tcp/options.go 41.66% <0.00%> (-1.99%) ⬇️
dtls/options.go 44.62% <25.00%> (-2.33%) ⬇️
udp/client/clientconn.go 70.94% <25.00%> (+1.20%) ⬆️
udp/options.go 55.37% <25.00%> (-2.89%) ⬇️
tcp/server.go 79.19% <60.00%> (+0.81%) ⬆️
net/client/client.go 60.57% <60.57%> (ø)
udp/discover.go 53.19% <66.66%> (-0.30%) ⬇️
dtls/server.go 82.02% <69.23%> (-2.38%) ⬇️
dtls/client.go 82.79% <71.42%> (ø)
... and 10 more

@jkralik jkralik force-pushed the jkralik/feature/mergeCommonClientConnCommands branch 2 times, most recently from 9c09484 to 6d88e62 Compare July 20, 2022 13:10
@jkralik jkralik force-pushed the jkralik/feature/mergeCommonClientConnCommands branch 3 times, most recently from f8df959 to 7f9d8ff Compare July 21, 2022 08:57
Base automatically changed from jkralik/feature/cleanupBW to v3 July 21, 2022 10:25
@jkralik jkralik force-pushed the jkralik/feature/mergeCommonClientConnCommands branch from 7f9d8ff to b2f5d72 Compare July 21, 2022 10:26
@jkralik jkralik force-pushed the jkralik/feature/mergeCommonClientConnCommands branch from b2f5d72 to 5e25b39 Compare July 21, 2022 10:30
@jkralik jkralik merged commit 14ade7e into v3 Jul 21, 2022
@jkralik jkralik deleted the jkralik/feature/mergeCommonClientConnCommands branch July 21, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants