fix leaking of pool.Message #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkralik
force-pushed
the
jkralik/fix/processParallelHandshakes
branch
from
fb674c0
to
016aee1
Compare
jkralik
force-pushed
the
jkralik/fix/improveBlockwise
branch
from
c101f5b
to
4d45d54
Compare
Codecov Report
@@ Coverage Diff @@
## v3 #381 +/- ##
==========================================
- Coverage 70.39% 70.17% -0.22%
==========================================
Files 68 67 -1
Lines 5174 5089 -85
==========================================
- Hits 3642 3571 -71
+ Misses 1149 1136 -13
+ Partials 383 382 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jkralik
force-pushed
the
jkralik/fix/improveBlockwise
branch
from
4d45d54
to
71b285c
Compare
Danielius1922
approved these changes
Aug 15, 2022
| @@ -462,8 +430,8 @@ func (b *BlockWise[C]) Handle(w *responsewriter.ResponseWriter[C], r *pool.Messa | |||
| b.errors(fmt.Errorf("continueSendingMessage(%v): %w", r, err)) | |||
| return | |||
| } | |||
| if b.autoCleanUpResponseCache && !more { | |||
| b.RemoveFromResponseCache(token) | |||
| if !more && sendingMessageCached.Data().Code() > codes.DELETE { | |||
There was a problem hiding this comment.
Are codes > than codes.DELETE invalid or why are only those codes deleted from cache?
There was a problem hiding this comment.
For codes GET,POST,PUT,DELETE, we want them to wait for pairing response and then delete them when the full response comes in or when timeout occurs.
jkralik
force-pushed
the
jkralik/fix/improveBlockwise
branch
from
71b285c
to
317fb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.