-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix comment on function SetObserve #391
Conversation
Signed-off-by: aryan <aryangodara03@gmail.com>
@Danielius1922 , Should I fix the issues, to pass the |
Hey, thanks for the fix, I think I've fixed those and other issues in PR #390, so it's already done. Thus nothing here needs to be done, I'll merge. |
@Danielius1922 , I had a request. |
No mocking features like those offered by httptest are available currently. I've looked at the source of the httptest library and it's powerful yet small (only 3 implementation files), so creating something like that is possible. We've talked about this with @jkralik and we both agree it would be a nice enhancement, but it's unlikely we will get to it any time soon, the plan is to finish v3 first and then we can look into new features. So currently the only way I can think of doing what you need is: create a newServer function that makes a coap server running on localhost on some port in a separate go-routine with selected uri handlers. Then call newServer at the start of each client test case. But this is basically the implementation of httptest equivalent. If you go that way you might as well contribute it here, I might have some time to help (usually I have few hours on a Friday to spare). (Not much of a help I know, sorry. BTW nice avatar, I hope HxH doesn't end up unfinished like Berserk.) |
Thanks for the reply @Danielius1922 . I'll try to implement this, and will update if I get to this task of creating a mock server. (I too hope I get to see the entire HxH story 😄) |
Signed-off-by: aryan aryangodara03@gmail.com
With reference to issue #384