Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linters and fix reported issues #393

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

Danielius1922
Copy link
Member

Removed linters:

  • deadcode (obsolete)
  • varcheck (obsolete)

Enabled linters:

  • forcetypeassert
  • gocritic
  • gocyclo
  • gomoddirectives
  • gomodguard
  • nilerr
  • revive
  • unparam

Removed linters:
  - deadcode (obsolete)
  - varcheck (obsolete)

Enabled linters:
  - forcetypeassert
  - gocritic
  - gocyclo
  - gomoddirectives
  - gomodguard
  - nilerr
  - revive
  - unparam
@Danielius1922 Danielius1922 marked this pull request as ready for review September 21, 2022 11:07
@codecov-commenter
Copy link

Codecov Report

Merging #393 (8725987) into v3 (ba2022c) will increase coverage by 0.08%.
The diff coverage is 78.87%.

@@            Coverage Diff             @@
##               v3     #393      +/-   ##
==========================================
+ Coverage   70.26%   70.35%   +0.08%     
==========================================
  Files          67       67              
  Lines        5085     5110      +25     
==========================================
+ Hits         3573     3595      +22     
+ Misses       1131     1128       -3     
- Partials      381      387       +6     
Impacted Files Coverage Δ
dtls/server/config.go 64.28% <ø> (ø)
message/getmid.go 80.00% <0.00%> (ø)
options/udpOptions.go 34.61% <ø> (ø)
udp/client/config.go 75.00% <ø> (+8.33%) ⬆️
udp/server/config.go 71.42% <ø> (ø)
message/pool/pool.go 84.00% <33.33%> (-7.31%) ⬇️
dtls/server/server.go 77.03% <57.14%> (+0.95%) ⬆️
net/connUDP.go 61.32% <71.42%> (-0.68%) ⬇️
tcp/coder/coder.go 70.92% <71.42%> (-0.51%) ⬇️
tcp/server/server.go 77.51% <71.42%> (+1.00%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik merged commit ede835f into v3 Sep 21, 2022
@jkralik jkralik deleted the adam/feature/v3-enable-linters branch September 21, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants