Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix returned block size in blockwise transfer #394

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

ljupcho
Copy link

@ljupcho ljupcho commented Sep 14, 2022

Steps to reproduce:

  1. Run a server for example on port 5688
  2. Using coap client (https://libcoap.net/doc/reference/4.2.0/man_coap-client.html) run a request with giving block size, ex:
    coap-client -T token -b 16 -v 9 -m get 'coap://localhost:5688/a'

Actual result:
Server ignores the Block2 option of 16 and returned whole response in single block as default server config is 1024 bytes SZX and this maxSZX from server is used instead of suggested size from client.

Expected result:
There should be multiple blocks with single block containing max 16 characters of transferred content as specified with flag "-b 16".

@jkralik jkralik merged commit 5032ea4 into plgd-dev:master Sep 16, 2022
@jkralik
Copy link
Member

jkralik commented Sep 16, 2022

Thx for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants