Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration time customization to the cache #402

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

lubo-svk
Copy link
Collaborator

@lubo-svk lubo-svk commented Oct 3, 2022

No description provided.

pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/cache/cache.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #402 (91589ac) into master (17bbcc3) will increase coverage by 0.02%.
The diff coverage is 87.50%.

❗ Current head 91589ac differs from pull request most recent head 697798c. Consider uploading reports for the commit 697798c to get more accurate results

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   70.59%   70.61%   +0.02%     
==========================================
  Files          68       68              
  Lines        5747     5748       +1     
==========================================
+ Hits         4057     4059       +2     
+ Misses       1292     1291       -1     
  Partials      398      398              
Impacted Files Coverage Δ
net/blockwise/blockwise.go 69.00% <50.00%> (ø)
pkg/cache/cache.go 94.54% <100.00%> (+0.10%) ⬆️
udp/client/clientconn.go 71.90% <100.00%> (ø)
tcp/clientobserve.go 66.00% <0.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lubo-svk lubo-svk marked this pull request as ready for review October 4, 2022 14:19
@jkralik jkralik merged commit 7f33ba0 into master Oct 4, 2022
@jkralik jkralik deleted the feature/cache-with-customizable-timeout branch October 4, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants