New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jkralik/feature/improve go pool #404

Merged

jkralik merged 2 commits into v3 from jkralik/feature/improveGoPool

Oct 7, 2022

Member

jkralik commented Oct 4, 2022

No description provided.

jkralik requested a review from Danielius1922

October 4, 2022 09:28

jkralik changed the base branch from master to v3

October 4, 2022 09:28

codecov-commenter commented Oct 4, 2022

Codecov Report

Merging #404 (dcc7042) into v3 (b2e91ea) will decrease coverage by 0.31%.
The diff coverage is 75.88%.

@@            Coverage Diff             @@
##               v3     #404      +/-   ##
==========================================
- Coverage   70.45%   70.13%   -0.32%     
==========================================
  Files          68       68              
  Lines        5195     5220      +25     
==========================================
+ Hits         3660     3661       +1     
- Misses       1149     1177      +28     
+ Partials      386      382       -4

Impacted Files	Coverage Δ
message/options.go	`75.13% <ø> (ø)`
message/status/status.go	`0.00% <0.00%> (ø)`
options/commonOptions.go	`42.06% <46.15%> (-1.02%)`	⬇️
net/blockwise/blockwise.go	`68.75% <76.92%> (+0.25%)`	⬆️
udp/client/conn.go	`71.94% <78.04%> (-0.74%)`	⬇️
dtls/server/config.go	`64.28% <100.00%> (ø)`
message/pool/message.go	`75.63% <100.00%> (+0.07%)`	⬆️
message/pool/pool.go	`92.00% <100.00%> (ø)`
net/conn.go	`85.93% <100.00%> (-3.13%)`	⬇️
net/connUDP.go	`60.54% <100.00%> (-1.57%)`	⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Danielius1922 reviewed

View reviewed changes

options/config/common.go Outdated Show resolved Hide resolved

jkralik force-pushed the jkralik/feature/improveGoPool branch 3 times, most recently from 5a77aac to e940c89 Compare

October 4, 2022 14:36


          expose goPool parameters

5b1f230

jkralik force-pushed the jkralik/feature/improveGoPool branch from e940c89 to 5b1f230 Compare

October 5, 2022 06:06


          workflows: use newest golang

0b5741f

jkralik force-pushed the jkralik/feature/improveGoPool branch from 11ea0c1 to 0b5741f Compare

October 5, 2022 06:24

Member Author

jkralik commented Oct 5, 2022

We need to wait for PR: actions/go-versions#60

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

67.8% Coverage
5.7% Duplication

Danielius1922 approved these changes

View reviewed changes

jkralik merged commit 86eb155 into v3

jkralik deleted the jkralik/feature/improveGoPool branch

October 7, 2022 07:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment