Fix off-by-one error in upserts #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two off-by-one errors in the upsert functions for message ID and message type. UpsertMessageId should allow a value of 65535, while UpsertType should allow 255. Without this fix, a device sending a confirmable message to the server will receive an ACK message back with an incorrect Message ID. Co-authored-by: Vit Prajzler <28387418+vitprajzler@users.noreply.github.com>
jkralik
force-pushed
the
jkralik/fix/upsert-mid
branch
from
b7514f4
to
a620e34
Compare
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 71.34% 71.46% +0.12%
==========================================
Files 68 68
Lines 5255 5275 +20
==========================================
+ Hits 3749 3770 +21
+ Misses 1122 1119 -3
- Partials 384 386 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
message/getmid.go
Outdated
| @@ -28,3 +29,8 @@ func RandMID() int32 { | |||
| } | |||
| return int32(uint16(binary.BigEndian.Uint32(b))) | |||
| } | |||
|
|
|||
| // ValidateMessageID validates a message id for UDP. (0 <= mid <= 65535) | |||
| func ValidateMessageID(mid int32) bool { | |||
There was a problem hiding this comment.
I think ValidateMID would be more in line with the existing naming convention, but it's clear either way so I don't mind.
| @@ -46,10 +45,10 @@ func (c *Coder) Encode(m message.Message, buf []byte) (int, error) { | |||
| |1 1 1 1 1 1 1 1| Payload (if any) ... | |||
| +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | |||
| */ | |||
| if m.MessageID < 0 || m.MessageID > math.MaxUint16 { | |||
There was a problem hiding this comment.
Maybe a test of Encode with the boundary values for messageID and type?
Danielius1922
approved these changes
Jan 9, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two off-by-one errors in the upsert functions for message ID and message type.
UpsertMessageId should allow a value of 65535, while UpsertType should allow 255.
Without this fix, a device sending a confirmable message to the server will receive an ACK message back with an incorrect Message ID.
FYI: @mniestroj @vitprajzler