New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarCloud: lower complexity of upd/client.writeMessage #425

Merged

Danielius1922 merged 2 commits into master from adam/feature/sc-fixes-1

Jan 11, 2023

Member

Danielius1922 commented Jan 9, 2023

No description provided.

Danielius1922 requested a review from jkralik

January 9, 2023 09:43

codecov-commenter commented Jan 9, 2023 •

edited

Codecov Report

Merging #425 (4f4f616) into master (ac1d638) will decrease coverage by 0.07%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   71.52%   71.45%   -0.08%     
==========================================
  Files          68       69       +1     
  Lines        5271     5289      +18     
==========================================
+ Hits         3770     3779       +9     
- Misses       1121     1123       +2     
- Partials      380      387       +7

Impacted Files	Coverage Δ
udp/client/conn.go	`72.70% <72.22%> (-0.23%)`	⬇️
pkg/fn/funcList.go	`100.00% <100.00%> (ø)`
...ent/limitParallelRequests/limitParallelRequests.go	`86.95% <0.00%> (-5.80%)`	⬇️
net/dtlslistener.go	`67.34% <0.00%> (-2.05%)`	⬇️
tcp/coder/coder.go	`70.92% <0.00%> (-1.42%)`	⬇️
tcp/client/session.go	`73.95% <0.00%> (-0.94%)`	⬇️
message/message.go	`80.00% <0.00%> (ø)`
message/pool/message.go	`75.63% <0.00%> (ø)`
message/getmid.go	`83.33% <0.00%> (+3.33%)`	⬆️
udp/coder/coder.go	`72.54% <0.00%> (+5.88%)`	⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Danielius1922 force-pushed the adam/feature/sc-fixes-1 branch from d4ea049 to 79799d5 Compare

January 9, 2023 16:09

jkralik reviewed

View reviewed changes

pkg/fn/funcList.go Outdated Show resolved Hide resolved

Danielius1922 force-pushed the adam/feature/sc-fixes-1 branch from 79799d5 to 4f4f616 Compare

January 11, 2023 14:48

Danielius1922 added 2 commits

January 11, 2023 16:19


          SonarCloud: lower complexity of upd/client.writeMessage

ef00abd


          fixup! SonarCloud: lower complexity of upd/client.writeMessage

66684e5

Danielius1922 force-pushed the adam/feature/sc-fixes-1 branch from 4f4f616 to 66684e5 Compare

January 11, 2023 15:19

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

77.8% Coverage
0.0% Duplication

jkralik approved these changes

View reviewed changes

Danielius1922 merged commit 01faa43 into master

Danielius1922 deleted the adam/feature/sc-fixes-1 branch

January 11, 2023 17:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment