Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loss of order of messages #426

Merged
merged 8 commits into from
Jan 25, 2023
Merged

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jan 21, 2023

using goPool causes loss of order of messages. For example coap notfications comes in order, but goroutines from gopool are executed underministic.

  • WithGoPool was removed
  • WithProcessReceivedMessageFunc to modify core cc.ProcessReceivedMessage

using goPool causes loss of order of messages. For example
coap notfications comes in order, but goroutines from gopool
are executed underministic.

- WithGoPool was removed
- WithProcessReceivedMessageFunc to modify core cc.ProcessReceivedMessage
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Merging #426 (8068e59) into master (01faa43) will decrease coverage by 0.03%.
The diff coverage is 74.65%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   71.46%   71.44%   -0.03%     
==========================================
  Files          69       70       +1     
  Lines        5289     5484     +195     
==========================================
+ Hits         3780     3918     +138     
- Misses       1122     1171      +49     
- Partials      387      395       +8     
Impacted Files Coverage Δ
dtls/server/config.go 71.42% <ø> (+7.14%) ⬆️
options/config/common.go 100.00% <ø> (ø)
udp/server/config.go 71.42% <ø> (ø)
options/commonOptions.go 43.39% <60.86%> (+1.33%) ⬆️
tcp/client/conn.go 69.72% <68.23%> (-3.32%) ⬇️
udp/client/conn.go 69.47% <71.61%> (-3.23%) ⬇️
message/pool/message.go 76.11% <84.21%> (+0.48%) ⬆️
dtls/server/server.go 76.47% <100.00%> (-0.57%) ⬇️
net/client/receivedMessageReader.go 100.00% <100.00%> (ø)
tcp/client/session.go 80.14% <100.00%> (+6.18%) ⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik force-pushed the jkralik/fix/loss-of-order-of-messages branch from b3a810b to 5b0e865 Compare January 23, 2023 09:03
@jkralik jkralik marked this pull request as ready for review January 23, 2023 09:07
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

75.9% 75.9% Coverage
0.1% 0.1% Duplication

@jkralik jkralik merged commit 3b55161 into master Jan 25, 2023
@jkralik jkralik deleted the jkralik/fix/loss-of-order-of-messages branch January 25, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants