-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix loss of order of messages #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using goPool causes loss of order of messages. For example coap notfications comes in order, but goroutines from gopool are executed underministic. - WithGoPool was removed - WithProcessReceivedMessageFunc to modify core cc.ProcessReceivedMessage
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 71.46% 71.44% -0.03%
==========================================
Files 69 70 +1
Lines 5289 5484 +195
==========================================
+ Hits 3780 3918 +138
- Misses 1122 1171 +49
- Partials 387 395 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jkralik
force-pushed
the
jkralik/fix/loss-of-order-of-messages
branch
from
January 23, 2023 09:03
b3a810b
to
5b0e865
Compare
Kudos, SonarCloud Quality Gate passed! |
Danielius1922
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using goPool causes loss of order of messages. For example coap notfications comes in order, but goroutines from gopool are executed underministic.
cc.ProcessReceivedMessage