Blockwise: Allow transfer via NonConfirmable messages

[azambranogalbis]

Fixes #547

Summary by CodeRabbit

• Bug Fixes
  • Ensured the request type is correctly set during write operations, enhancing reliability and consistency in data handling.
  • Added a condition to set the type of the request based on the type of the incoming message in the newWriteRequestResponse function.

[coderabbitai]

Warning

Rate Limit Exceeded

@jkralik has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 921ef07 and f39d581.

Walkthrough

The recent change in the blockwise.go file ensures that the type of CoAP messages (confirmable or non-confirmable) is correctly maintained when blockwise transfer is enabled. This addresses the issue where non-confirmable responses were erroneously treated as confirmable in blockwise UDP connections.

Changes

File	Change Summary
net/.../blockwise.go	Added condition to set the request type based on the incoming message type in blockwise responses

Assessment against linked issues

Objective	Addressed	Explanation
Allow sending non-confirmable responses over blockwise UDP connection (#547)	✅

Possibly related issues

• Implement Support for Separate Messages in Server #474: While this issue focuses on separate message handling, maintaining message types (confirmable/non-confirmable) is crucial for correct separate message processing. This change could be beneficial if separate messages require specific types.

🐇🌟
A small tweak in the code, a message is clear,
Ensuring the types of messages we hold dear.
Non-confirmable responses, now they glide,
Through blockwise connections, with pride.
The fix is in, the solution near! 🌟🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 1