Make Color to be scoped enumeration

[tiendq]

Highly recommended http://www.stroustrup.com/C++11FAQ.html#enum

[plibither8]

I read the reference. How are the advantages directly linked to this project? Just asking since I can't get hold of the direct advantages of it 😄.

[tiendq]

Short answer, it’s safer then safer code is a pratice we should follow especially it’s easy to do :)

Exactly it’s a new C++ feature that we should use, except you are maintaining an old C code base :)

It says all in this code (copied):

enum class Color { red, blue }; // scoped and strongly typed enum
// no export of enumerator names into enclosing scope
// no implicit conversion to int

[tiendq]

I'd like to add another link, it's styled better than previous one :). I just found many others enum (I didn't look at them yesterday), it's not a high priority task but I suggest you to change them all to enum class.

https://isocpp.org/wiki/faq/cpp11-language-types#enum-class

[plibither8]

Yes, the second link was more enlightening, thanks :). I see the difference now, I'll merge the PRs soon.

…

On Sat, Oct 27, 2018, 6:07 AM Tien Do ***@***.***> wrote: I'd like to add another link, it's styled better than previous one :). I just found many others enum (I didn't look at them yesterday), it's not a high priority task but I suggest you to change them all to enum class. https://isocpp.org/wiki/faq/cpp11-language-types#enum-class — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#62 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeYr-7uLpr1BmvkXHHbIQlOuijLGxWiwks5uo6rXgaJpZM4X79Gj> .

[cawvyoct]

This is needed because of C.164 of the C++ Core Guidelines especially:

Do not introduce implicit conversions (through conversion operators or non-explicit constructors) just to gain a minor convenience.