Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async and includes as names in a few places #42

Closed
domenic opened this issue Aug 14, 2019 · 5 comments
Closed

Allow async and includes as names in a few places #42

domenic opened this issue Aug 14, 2019 · 5 comments

Comments

@domenic
Copy link
Contributor

domenic commented Aug 14, 2019

Corresponding Web IDL spec change: whatwg/webidl#769
@domenic domenic mentioned this issue Aug 19, 2019
Closed
This was referenced Aug 19, 2019
Merged
Closed
@foolip
Copy link
Contributor

foolip commented Aug 19, 2019

#43 fixes the argument name part of this which is blocking whatwg/xhr#251, I haven't looked for where to fix async as an attribute name, or includes anywhere.

@plinss plinss closed this as completed in c1f3008 Aug 20, 2019
@plinss
Copy link
Owner

plinss commented Aug 20, 2019

Ping @tabatkins

@foolip
Copy link
Contributor

foolip commented Aug 20, 2019

This isn't entirely fixed, I just fixed one case that affected the XHR spec.

@plinss
Copy link
Owner

plinss commented Aug 20, 2019

@foolip I fixed the other cases in c1f3008 lmk if I mIssed anything.

@foolip
Copy link
Contributor

foolip commented Aug 20, 2019

Oh, I see, I thought #43 resolved this, which would have been wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foolip @domenic @plinss