Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The open() method's "async" argument is now invalid per IDL #251

Closed
tabatkins opened this issue Aug 9, 2019 · 7 comments · Fixed by whatwg/webidl#769
Closed

The open() method's "async" argument is now invalid per IDL #251

tabatkins opened this issue Aug 9, 2019 · 7 comments · Fixed by whatwg/webidl#769

Comments

@tabatkins
Copy link

Since the async iterator<> feature was added to WebIDL, async now tokenizes as a keyword, not an ident, and thus is invalid as an argument name. You need to prefix it with a _, like _async.

@annevk
Copy link
Member

annevk commented Aug 12, 2019

Will whatwg/webidl#769 fix this @saschanaz?

@tabatkins
Copy link
Author

Assuming the edits in that PR are valid, yes it does.

@saschanaz
Copy link
Member

It does not solve this because it only covers operations and attributes. I can modify the PR to cover this.

@annevk
Copy link
Member

annevk commented Aug 19, 2019

Do we still need a Bikeshed or widlparser update? #252 is failing to build at the moment because of this (I think).

@foolip
Copy link
Member

foolip commented Aug 19, 2019

The Bikeshed change that introduced this was speced/bikeshed@450e049, and the Travis build for it did fail: https://travis-ci.org/tabatkins/bikeshed/builds/569899644

Changes around the open() method show up in the diff.

I think Bikeshed needs an update, so I've filed speced/bikeshed#1507 for that, and speced/bikeshed#1506 for process which allowed for the regression.

@foolip
Copy link
Member

foolip commented Aug 19, 2019

I've sent speced/bikeshed#1509 and confirmed that fixes the problem with make local for this spec.

@annevk
Copy link
Member

annevk commented Jul 16, 2020

This was resolved some time ago \o/

@annevk annevk closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants