As/tv os

[asowers1]

Summation of pull request

This PR is intends to add tvOS support to ConsistencyManager-iOS (which may have a confusing naming scheme if made multi-platform?)

Project additions

ConsistencyManager project:

• Adds appletvos and appletvsimulator as supported platforms
• Adds TARGETED_DEVICE_FAMILY 3 (for tvOS) in project file

SampleApp / ConsistencyManagerDemo project:

• Adds ConsistencyManagerDemo-tvOS target to ConsistencyManagerDemo project
• Ports ConsistencyManagerDemo to ConsistencyManagerDemo-tvOS
• Adds ConsistencyManagerDemoTests files to ConsistencyManagerDemo-tvOSTests target membership

Cocoapods:

• Suggests 5.1.0 pod release in podspec
• Adds tvos requirements to podspec

Misc:

• Some xibs opened with Xcode 8.2.1; automatically modified xib files

Demo app for tvOS:

Cool tidbits

Per http://promisekit.org/news/2016/08/Multiplatform-Single-Scheme-Xcode-Projects/, including tvOS support in the ConsistencyManager target.

[plivesey]

So first of all, thanks for the PR. Good point with -iOS. Created #50.

[plivesey]

Going to pull this down locally and take a look at the changes.

[asowers1]

👌

[plivesey]

Going to look over the code. Mostly looks good but a couple of comments so far:

1. In the demo app, there's still a scheme for ConsistencyManager which doesn't do anything anymore (UI shows it as a cog). Can we delete that?
2. In the demo app, there's some code which is exactly the same. Can we move that to a shared folder or something and just add it to both targets? I think just the models and the Network folder.

[plivesey]

Can you also make it so that we run tests on tvOS. you need to edit the build.sh and add another clean derived data and run tests on the right sdk. Something like:

rm -rf $DERIVED_DATA &&
time xcodebuild clean test \
    -project ConsistencyManager.xcodeproj \
    -scheme ConsistencyManager \
    -sdk macosx \ <--- this should be tvOS though? or something?
    -derivedDataPath $DERIVED_DATA \
    | tee build.log \
    | xcpretty &&

We don't test the demo app with travis btw, so just the main project.

[plivesey]

Nice. Thanks.

[plivesey]

Can we remove these UI tests? I highly doubt we'll ever write UI tests for the demo app and it's just cruft.

[asowers1]

This should probably do it for xcodebuild: rm -rf $DERIVED_DATA && time xcodebuild clean build \ -project ConsistencyManager.xcodeproj \ -scheme ConsistencyManager \ -sdk appletvsimulator10.0 \ -derivedDataPath $DERIVED_DATA \ -destination 'platform=tvOS Simulator,name=Apple TV 1080p,OS=10.0' \ | tee build.log \ | xcpretty &&

[asowers1]

https://github.com/linkedin/LayoutKit/blob/master/build.sh

[plivesey]

Left a couple of comments on the code too, but all minor stuff. Then can merge this in. :D

[asowers1]

I'll patch these up and push 👍

[asowers1]

I'm not seeing the empty scheme for ConsistencyManager in the SampleApp project. Is it still in there after this push?

[plivesey]

I'll check on the empty scheme, but don't worry about that either way. It may be a local thing, and we can delete that later. Checking changes.

[plivesey]

Yep. LGTM. Merging.

[asowers1]

🎉 Thanks!