Support Carthage

[floriankrueger]

This commit adds a Cartfile that specifies the dependency to ConsistencyManager-iOS. The pull request is depending on the ConsistencyManager-iOS-PR-32 which provides better Carthage support.

For now, I've specified any version of the consistency manager compatible with 2.0.0 but you should better specify the next (minor?) release version that contains the PR listed above (s.th. like 2.0.1 but that's up to you and how you like to version).

If you want, I could also add installation instructions for Carthage to the Readme.

Thanks!

[codecov-io]

Current coverage is 89.89% (diff: 100%)

Merging #30 into master will not change coverage

@@             master        #30   diff @@
==========================================
  Files            43         43          
  Lines          4524       4524          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           4067       4067          
  Misses          457        457          
  Partials          0          0          

Powered by Codecov. Last update 5efb4d4...08565c5

[plivesey]

To be clear, you want me to re-release the Consistency Manager with a new version right? 2.0.1 sounds good to me and can do that easily. Just wanted to make sure that's what you needed?

[plivesey]

And yeah, adding Carthage instructions to the README would be great.

[floriankrueger]

Hi, thanks for the quick response! I've updated the PR with installation instructions for Carthage and I removed the explicit version dependency from the Cartfile. Carthage will take the latest release anyways so it's just important that you make a new release of both RocketData and ConsistencyManager at roughly the same time to get full Carthage support. Patch versions are perfect for that as there are no code changes. Thank you!

[plivesey]

I'm working on OSX support for the Consistency Manager and expect to get that done today.

I'll probably release a new version with both these updates (hopefully also today).

[plivesey]

Changes look good though, merging.

[plivesey]

Oh...actually...I'm going to wait until it actually works to merge. Otherwise, people may be confused when they see the README.

[plivesey]

Released, so merging this in.

[plivesey]

Can you verify that it works?

[floriankrueger]

Hi @plivesey, thank you for merging. Unfortunately you also need to tag a new release for RocketData itself, b/c Carthage takes the latest release here as well:

$ cat Cartfile
github "linkedin/RocketData"
$ carthage update RocketData
*** Fetching RocketData
*** Checking out RocketData at "1.1.0"
*** xcodebuild output can be found in /var/folders/qj/38k1t5d52rb_h3y8bbhgc4lc0000gn/T/carthage-xcodebuild.JD4lKy.log
*** Building scheme "RocketData" in RocketData.xcworkspace

Until you make a new release, we can force Carthage to pull the latest commit from master.

$ cat Cartfile
github "linkedin/RocketData" "master"
$ carthage update RocketData
*** Fetching RocketData
*** Fetching ConsistencyManager-iOS
*** Checking out ConsistencyManager-iOS at "2.0.1"
*** Checking out RocketData at "90df908fe9c4ca8fc5fdccd77123a0937ce3f581"
*** xcodebuild output can be found in /var/folders/qj/38k1t5d52rb_h3y8bbhgc4lc0000gn/T/carthage-xcodebuild.mLln9u.log
*** Building scheme "ConsistencyManager" in ConsistencyManager.xcodeproj
*** Building scheme "RocketData" in RocketData.xcworkspace

Notice the "master" in the Cartfile. Now it correctly retrieves the dependency for RocketData and builds the ConsistencyManager.

Would be great if you could create a new RocketData release at some point in the future. Thanks!

[plivesey]

Yes. Will do. I'll create an issue so I don't forget.
Hopefully today/tomorrow.

[plivesey]

@floriankrueger I released a new version (1.1.1)