Support for 'macOS'

[KevinVitale]

Just saw the video presentation, and I'm eager to use the framework. Curious what the delta is to supporting macOS, also?

[plivesey]

I haven't worked with macOS before. I don't think it would be much...Rocket Data only relies on Foundation so that should be fine right?

Consistency Manager has a depenedency on UIKit but this is only for handling UIApplicationDidReceiveMemoryWarningNotification. Is this different on macOS?

[nicksnyder]

As a data point, it wasn't that difficult to support macOS for LayoutKit. Just need to create a new target (make sure it produces the same named library) and shim things if possible.

https://github.com/linkedin/LayoutKit/pull/11/files

[plivesey]

So UIKit is not OK for tvOS? It that's the main thing that's different, it should be really easy. But, not sure how to handle memory warnings on tvOS.

[nicksnyder]

iOS -> UIKit (e.g. UIView, UIApplication, etc.)
macOS -> AppKit (e.g. NSView, NSApplication, etc.)

tvOS has UIKit (but this issue is about macOS)

To support both, I was able to just create shims for UIKit and AppKit
https://github.com/linkedin/LayoutKit/blob/master/LayoutKit/UIKitSupport.swift
https://github.com/linkedin/LayoutKit/blob/master/LayoutKit/AppKitSupport.swift

e.g. my code uses View which maps to UIView on iOS and NSView on macOS.
The API aren't guaranteed to be identical but they mostly are.

[plivesey]

oh haha...just noticed this is asking about macOS not iOS. Yeah, that makes sense.

So yeah, I think supporting this should be trivial. I'll take a look later today and see where I get.

[plivesey]

Update: I've worked out the code changes necessary to do this, but can't work out the code signing issues. Whenever I run tests, it says: Failed to code sign "ConsistencyManagerTests".. Unclear why it cares for mac but not for iOS...

[plivesey]

@nicksnyder did you have any problems with this for LayoutKit?

[nicksnyder]

I don't remember running into codesign issues. I created a separate target for the macOS tests, did you do that too?

[KevinVitale]

I believe Code Signing can be disabled for macOS targets

[plivesey]

I disabled it...but it still complains. My branch is osx if you have time to take a look. Will investigate more soon.

[plivesey]

https://github.com/linkedin/ConsistencyManager-iOS/tree/osx

[plivesey]

https://github.com/linkedin/ConsistencyManager-iOS/pull/33/files

[plivesey]

Running into more problems with Rocket Data. It looks like I may need multiple workspaces to support this if I want to use cocoapods. I don't think you can have a Podfile which supports multiple platforms.

[asowers1]

Howdy 👋 Would the help wanted request also apply to tvOS? I've already made some headway with ConsistencyManager: https://github.com/asowers1/ConsistencyManager-iOS/tree/as/tvOS . Also, I think you can have a Podfile that supports multiple platforms in the same workspace.

[plivesey]

Yes. Would definitely welcome help on tvOS too. I'd definitely welcome prs and can help with any questions you may have.

…

On Fri, Jan 6, 2017 at 5:37 PM Andrew Sowers ***@***.***> wrote: Howdy 👋 Would the help wanted request also apply to tvOS? I've already made some headway with ConsistencyManager: https://github.com/asowers1/ConsistencyManager-iOS/tree/as/tvOS . Also, I think you can have a Podfile that supports multiple platforms in the same workspace. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMNTcKsZjKtQMWBq4MfsiAM9_4k-BAVks5rPuxygaJpZM4JorZA> .

[asowers1]

plivesey/ConsistencyManager#49

[hebertialmeida]

I guess we can close this, now that we support iOS, macOS, tvOS...

[plivesey]

Agreed.