Skip to content

Commit

Permalink
Merge pull request #139 from plivo/invalid_number_sms
Browse files Browse the repository at this point in the history
Invalid number sms
  • Loading branch information
nixonsam committed Jul 31, 2019
2 parents 1cf51b2 + 89e07c1 commit a3965c5
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,8 @@
# Change Log

## [v4.3.4](https://github.com/plivo/plivo-php/releases/tag/v4.3.4) - 2019-07-31
- Add logic to handle invalid numbers for bulk SMS

## [v4.3.3](https://github.com/plivo/plivo-php/releases/tag/v4.3.3) - 2019-04-15
- Fix responses to return HTTP status codes.

Expand Down
7 changes: 7 additions & 0 deletions Jenkinsfile
@@ -0,0 +1,7 @@
#!groovy

@Library('plivo_standard_libs@sdks') _

sdksPipeline ([
buildContainer: 'plivo/jenkins-ci/base/alpine/3.7:18.02.06.145'
])
2 changes: 2 additions & 0 deletions ci/config.yml
@@ -0,0 +1,2 @@
---
language: php-sdk
5 changes: 4 additions & 1 deletion src/Plivo/Resources/Message/MessageCreateResponse.php
Expand Up @@ -18,10 +18,13 @@ class MessageCreateResponse extends ResponseUpdate
* @param $message
* @param array $messageUuid
*/
public function __construct($message, array $messageUuid, $apiId,$statusCode)
public function __construct($message, array $messageUuid, $apiId,$statusCode, $invalid_number)
{
parent::__construct($apiId, $message,$statusCode);
$this->messageUuid = $messageUuid;
if($invalid_number != []){
$this->invalid_number = $invalid_number;
}
}

/**
Expand Down
3 changes: 2 additions & 1 deletion src/Plivo/Resources/Message/MessageInterface.php
Expand Up @@ -180,7 +180,8 @@ public function create($src, array $dst, $text,
$responseContents['message'],
$responseContents['message_uuid'],
$responseContents['api_id'],
$response->getStatusCode()
$response->getStatusCode(),
$responseContents['invalid_number']
);
} else {
throw new PlivoResponseException(
Expand Down
2 changes: 1 addition & 1 deletion src/Plivo/Version.php
Expand Up @@ -25,7 +25,7 @@ class Version
/**
* @const int PHP helper library patch number
*/
const PATCH = 3;
const PATCH = 4;

/**
* @return string
Expand Down

0 comments on commit a3965c5

Please sign in to comment.