feat: make api/roadmap call from client #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
noticed that filling out the form from landing page is currently broken. working on fixing it. |
fixed |
|
ugh. it's late and i'm tired but 1151 is working on the demo site now:
cc @djmcquillan @whizzzkid |
whizzzkid
approved these changes
Nov 24, 2022
| if (usePendingChildren) { | ||
| pendingChildren = childrenParsed.map(({html_url}) => ({html_url, group: issueData.title, parentHtmlUrl: issueData.html_url})) | ||
| } else { | ||
| children = await resolveChildrenWithDepth(await resolveChildren(childrenParsed)) |
There was a problem hiding this comment.
nit: we can break this over multiple lines
Comment on lines
+9
to
+18
| const urlErrors: StarMapsIssueError[] = [] | ||
| errorsForUrl.forEach((starMapError) => { | ||
| urlErrors.push({ | ||
| // errors: | ||
| userGuideUrl: starMapError.userGuideUrl, | ||
| title: starMapError.title, | ||
| message: starMapError.message, | ||
| }); | ||
|
|
||
| }); |
There was a problem hiding this comment.
nit:
Suggested change
| const urlErrors: StarMapsIssueError[] = [] | |
| errorsForUrl.forEach((starMapError) => { | |
| urlErrors.push({ | |
| // errors: | |
| userGuideUrl: starMapError.userGuideUrl, | |
| title: starMapError.title, | |
| message: starMapError.message, | |
| }); | |
| }); | |
| const urlErrors: StarMapsIssueError[] = errorsForUrl.map(({ | |
| userGuideUrl, title, message | |
| }) => ({ | |
| userGuideUrl, title, message | |
| }); |
| if (globalLoadingState.get()) return; | ||
| const fetchRoadMapResponse = async () => { | ||
| globalLoadingState.start(); | ||
| const roadmapApiUrl = `${window.location.origin}/api/roadmap?owner=${owner}&repo=${repo}&issue_number=${issue_number}` |
There was a problem hiding this comment.
nit: we should map VERCEL_URL from process.env instead of relying on window.location.origin
https://vercel.com/docs/concepts/projects/environment-variables#system-environment-variables
There was a problem hiding this comment.
Unfortunately, that actually breaks for preview urls
whizzzkid
added a commit
that referenced
this pull request
Nov 25, 2022
* main: feat: make api/roadmap call from client (#181)
0xDanomite
pushed a commit
that referenced
this pull request
Nov 28, 2022
SgtPooki
added a commit
that referenced
this pull request
Nov 29, 2022
* fix: add landing page github linkout #150 * remove extra added code * github png logo * feat: make api/roadmap call from client (#181) * Codeclimate Coverage Reporter * fix * rename * Rename to CI * Adding badges * Updating * fix: coverage reporting for all files (#191) * removed github link from md and added to client * updated style of link back to orginal * chore: update starmapsGithubUrl Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com> Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this PR:
fix/bacalhau-1151-with-async-children)commits
This issue continues along with a number of other issues to resolve #158:
Prior to this change
browser network size and timing
After this change (from localhost)
browser network size
Initial page load timing
Roadmap API timing