feat: add telemetry #272
Merged
feat: add telemetry #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SgtPooki
commented
Jan 19, 2023
package.json
Outdated
| @@ -19,6 +19,7 @@ | |||
| "@emotion/react": "^11.10.4", | |||
| "@emotion/styled": "^11.10.4", | |||
| "@hookstate/core": "^4.0.0-rc21", | |||
| "@ipfs-shipyard/ignite-metrics": "https://github.com/ipfs-shipyard/ignite-metrics#feat/useStorageForBrowsers-with-dist", | |||
There was a problem hiding this comment.
will update when ipfs-shipyard/ignite-metrics#64 is merged and new ignite-metrics is released
lib/types.d.ts
Outdated
| @@ -157,3 +157,5 @@ export interface IssueDataViewInput { | |||
| // isRootIssueLoading: boolean; | |||
| // isPendingChildrenLoading: boolean; | |||
| } | |||
|
|
|||
| export type BrowserMetricsProvider = import('@ipfs-shipyard/ignite-metrics').BrowserMetricsProvider | |||
There was a problem hiding this comment.
safely getting the type here since importing it is sketchy with nextjs while this package is still cjs.
hooks/useTelemetry.ts
Outdated
Comment on lines
3
to
8
| import useSharedHook from '../lib/client/createSharedHook'; | ||
|
|
||
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const [useTelemetry, setTelemetry] = useSharedHook(useState, null); | ||
|
|
||
| export { useTelemetry, setTelemetry }; |
There was a problem hiding this comment.
be able to use telemetry object from anywhere.
0xDanomite
approved these changes
Jan 21, 2023
whizzzkid
approved these changes
Jan 23, 2023
whizzzkid
reviewed
Jan 24, 2023
| const { BrowserMetricsProvider } = await igniteMetricsModulePromise | ||
| const newTelemetry = new BrowserMetricsProvider({ appKey: '294089175b8268e44bc4e4fab572fe250d57b968' }) | ||
| // @ts-expect-error | ||
| window.telemetry = newTelemetry |
There was a problem hiding this comment.
window hookup can be automatic from the provider. Just wondering if we should add an issue.
There was a problem hiding this comment.
it could be useful, but this should be temporary until we add the UI treatments.. i didn't want to block on ignite-metrics any further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on ipfs-shipyard/ignite-metrics#64