Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on 2020-01-20-algebraic-data-types-arent-numbers-on-steroids.… #548

Merged
merged 1 commit into from Jan 21, 2020

Conversation

drewjcooper
Copy link
Contributor

…html

Add a comment

@ploeh ploeh merged commit c9184d5 into ploeh:master Jan 21, 2020
@github-pages github-pages bot temporarily deployed to github-pages January 21, 2020 06:43 Inactive
@ploeh
Copy link
Owner

ploeh commented Jan 21, 2020

Thank you for writing 👍 I'd considered replying to Jakub's comment, but yours amply does that.

Did you mean to respond to Jakub, or is the question directed at me?

@ploeh
Copy link
Owner

ploeh commented Jan 21, 2020

Well, regardless of who you directed your question at, you got a reply from Jakub 😄

@drewjcooper
Copy link
Contributor Author

Mark, I was intending the question for yourself. I'm not sure that the code in the original post supports the point you're trying to make in the text, but it's entirely possible that i'm missing something.

The Trade data type doesn't inherently prevent you from adding values of different currencies, although to solve the given problem you necessarily have to separate the currency types. This seems to me, though, to be a feature of the data processing algorithm, rather than the data type. Again, am I missing something?

@ploeh
Copy link
Owner

ploeh commented Jan 22, 2020

Okay, I just wanted to be sure. FWIW I've now left a response on the page. Please write again if you don't find it satisfactory 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants