Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when skopeo is not installed on local machine #117

Closed
cthiel1 opened this issue Feb 9, 2021 · 1 comment
Closed

Tests fail when skopeo is not installed on local machine #117

cthiel1 opened this issue Feb 9, 2021 · 1 comment

Comments

@cthiel1
Copy link
Contributor

cthiel1 commented Feb 9, 2021

Two of the 'test_skopeo_push_container_image.py' tests fail when the steprunner tests are run on a machine that does not have skopeo installed.

Failing tests:

  • TestStepImplementerSkopeoSourceBase.test_run_step_fail_run_skopeo
  • TestStepImplementerSkopeoSourceBase.test_run_step_pass

Output:

============================================================================================= short test summary info =============================================================================================
FAILED tests/step_implementers/push_container_image/test_skopeo_push_container_image.py::TestStepImplementerSkopeoSourceBase::test_run_step_fail_run_skopeo - AttributeError: <module 'sh' from '/home/cthiel/pl...
FAILED tests/step_implementers/push_container_image/test_skopeo_push_container_image.py::TestStepImplementerSkopeoSourceBase::test_run_step_pass - AttributeError: <module 'sh' from '/home/cthiel/ploigos-step-...
==================================================================================== 2 failed, 674 passed, 7 skipped in 9.39s =====================================================================================
ERROR: InvocationError for command /home/cthiel/ploigos-step-runner/.tox/test/bin/python -m pytest --cov --cov-report=term-missing --cov-report=xml (exited with code 1)

Once skopeo is installed on the local machine, these tests run without issue and all tests pass

Expected behavior: All tests should pass regardless of what tools are present on the local machine

itewk added a commit to itewk/ploigos-step-runner that referenced this issue Mar 22, 2021
itewk added a commit to itewk/ploigos-step-runner that referenced this issue Mar 22, 2021
…cal machine - set create=True for mocking skopeo
dwinchell pushed a commit that referenced this issue Mar 22, 2021
hatmarch added a commit to hatmarch/ploigos-step-runner that referenced this issue Mar 25, 2021
fix issue ploigos#117 - Tests fail when skopeo is not installed on local mac…
@itewk
Copy link
Contributor

itewk commented May 18, 2021

this is fixed now.

@itewk itewk closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants