add changenote

plone · Aug 14, 2018 · 7fbf5f0 · 7fbf5f0
1 parent e5efb3e
commit 7fbf5f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -6,15 +6,17 @@ Changelog
 
 Breaking changes:
 
-- *add item here*
+- Use ulines for view_methods in python 3.
+  [pbauer]
 
 New features:
 
 - *add item here*
 
 Bug fixes:
 
-- *add item here*
+- Migrate tests away from PloneTestCase.
+  [pbauer]
 
 
 5.0.0 (2018-06-20)

diff --git a/Products/CMFDynamicViewFTI/tests/test_fti.py b/Products/CMFDynamicViewFTI/tests/test_fti.py
@@ -2,7 +2,6 @@
 from plone.app.testing import TEST_USER_NAME
 from plone.app.testing import TEST_USER_PASSWORD
 from Products.CMFCore.interfaces import ITypeInformation
-from Products.CMFCore.utils import getToolByName
 from Products.CMFDynamicViewFTI.fti import DynamicViewTypeInformation
 from Products.CMFDynamicViewFTI.interfaces import IDynamicViewTypeInformation
 from Products.CMFDynamicViewFTI.tests import CMFDVFTITestCase
@@ -192,8 +191,8 @@ def test_NonFolderishObjectReturnsNone(self):
 
 
 if six.PY2:
-    # I have no idea what is or should be happending here.
-    # In py2 this test works but in py3 it yields:
+    # With AT having no layout renders the FSPageTemplate index_html
+    # In py3 this template cannot be called for some reason:
     # TypeError: 'ReplaceableWrapper' object is not callable
 
     class TestEmptyLayoutBug(CMFDVFTITestCase.CMFDVFTITestCase):