Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Using the navroot in 359a10d introduced a bug when the plonesite used…
… VHM: links to the mail_password_form on login_form contained the portal's path too. eg. plone.org/Plone/mail_password_form fixed by using navigationRootUrl which respects VHM settings
- Loading branch information
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a72a9c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esteele i heard there will never be a 4.4 release, or should i port this fix to 4.4.X branch too?
current master will become plone5 correct? iirc the registration and login related pages will we rewritten and skins/login_templates will become superflous. or will they stay there for bbb so i should add this (359a10d) and my commit there too?
a72a9c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a72a9c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your quick reply @esteele !
as 4.4 is not happening: can't we delete the 4.4.X branch?
i was not sure if 359a10d contains all necessary changes to make this work or if other packages/commits should be involved.
to make the new plone login not forget about this feature i filed a ticket: plone/plone.login#25
a72a9c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frisi i just got hit by this bug! thanks for the fix :)
i guess the port to the master branch is still missing?
a72a9c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thet yes, i did not fix this in master for 2 reasons
a) i was not sure if 359a10d contains all necessar changes or if it's just part of a bigger changeset.
b) plone5 won't use formcontroller templates but plone.login
this is why i just reported a ticket there.