Skip to content

Commit

Permalink
Using the navroot in 359a10d introduced a bug when the plonesite used…
Browse files Browse the repository at this point in the history
… VHM:

links to the mail_password_form on login_form contained the portal's path too. eg. plone.org/Plone/mail_password_form

fixed by using navigationRootUrl which respects VHM settings
  • Loading branch information
frisi committed Jul 18, 2014
1 parent b31e882 commit a72a9c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Products/CMFPlone/skins/plone_login/login_form.cpt
Expand Up @@ -24,7 +24,7 @@
<metal:login define-macro="login"
tal:define="auth nocall:context/acl_users/credentials_cookie_auth|context/cookie_authentication|nothing;
plone context/@@plone;
nav_root plone/navigationRootPath;
nav_root plone/navigationRootUrl;
isURLInPortal nocall:context/portal_url/isURLInPortal;
login_template_ids python:'login login_success login_password login_failed login_form logged_in logout logged_out registered mail_password mail_password_form register require_login member_search_results pwreset_finish localhost'.split();
came_from request/came_from|request/HTTP_REFERER|nothing;
Expand Down
7 changes: 5 additions & 2 deletions docs/CHANGES.rst
Expand Up @@ -8,6 +8,9 @@ Changelog
4.3.4 (unreleased)
------------------

- Fix link to the mail_password_form on the login_form for sites using VHM
[fRiSi]

- folder_position script: make position and id optional. Default
position to 'ordered' and id to None, which means: do nothing.
plone.folder 1.0.5 allows this, making it possible to simply reverse
Expand All @@ -24,7 +27,7 @@ Changelog
- Fix JavaScript to work with recent jQuery (>= 1.9) versions.
[thet]

- Improve event_view - do not show time when user specifies the same start and
- Improve event_view - do not show time when user specifies the same start and
end time for an event.
[spereverde]

Expand Down Expand Up @@ -221,7 +224,7 @@ Changelog
- Test for #7627 (https://dev.plone.org/ticket/7627)

4.3rc1 (released)
-------------------
-----------------

- add overlay for folder default page folder factories link
[vangheem]
Expand Down

5 comments on commit a72a9c1

@frisi
Copy link
Contributor Author

@frisi frisi commented on a72a9c1 Jul 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esteele i heard there will never be a 4.4 release, or should i port this fix to 4.4.X branch too?
current master will become plone5 correct? iirc the registration and login related pages will we rewritten and skins/login_templates will become superflous. or will they stay there for bbb so i should add this (359a10d) and my commit there too?

@esteele
Copy link
Member

@esteele esteele commented on a72a9c1 Jul 18, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frisi
Copy link
Contributor Author

@frisi frisi commented on a72a9c1 Jul 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your quick reply @esteele !
as 4.4 is not happening: can't we delete the 4.4.X branch?

i was not sure if 359a10d contains all necessary changes to make this work or if other packages/commits should be involved.
to make the new plone login not forget about this feature i filed a ticket: plone/plone.login#25

@thet
Copy link
Member

@thet thet commented on a72a9c1 Aug 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frisi i just got hit by this bug! thanks for the fix :)
i guess the port to the master branch is still missing?

@frisi
Copy link
Contributor Author

@frisi frisi commented on a72a9c1 Aug 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thet yes, i did not fix this in master for 2 reasons

a) i was not sure if 359a10d contains all necessar changes or if it's just part of a bigger changeset.

b) plone5 won't use formcontroller templates but plone.login

this is why i just reported a ticket there.

Please sign in to comment.