Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ootb collections have no type criteria #1040

Closed
fulv opened this Issue Sep 19, 2015 · 10 comments

Comments

Projects
None yet
4 participants
@fulv
Copy link
Member

fulv commented Sep 19, 2015

The events/aggregator and news/aggregator collections that come with a fresh Plone site seem to have empty type criteria set. There is one line of criteria, and the first select box says "Type", but the value select box is empty. Moreover, there are no types available to select.

However, if I add some future events to the site and publish them, the Events collection "View" shows them. But they do not show up in the Preview list in edit mode. Also, any private events are not shown, which indicates that there is also a workflow state criterion set in the collection, but it's not visible.

screen shot 2015-09-18 at 6 45 31 pm

@fulv fulv added this to the Plone 5.0 milestone Sep 19, 2015

@fulv fulv added the 01 type: bug label Sep 19, 2015

@esteele esteele modified the milestones: Plone 5.0.x, Plone 5.0 Sep 19, 2015

@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Nov 23, 2015

Problem is that we are setting the old plone.app.querystring.operation.selection.is instead of the new plone.app.querystring.operation.selection.any.

@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Nov 23, 2015

I will make a few pull requests that belong together.

@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Nov 23, 2015

BTW, workaround for existing sites: go to portal_setup and reapply the last plone.app.querystring upgrade steps, the ones that migrate from revision 11 to 13.

mauritsvanrees added a commit to plone/Products.ATContentTypes that referenced this issue Nov 23, 2015

mauritsvanrees added a commit to plone/plone.app.contenttypes that referenced this issue Nov 23, 2015

mauritsvanrees added a commit to plone/mockup that referenced this issue Nov 23, 2015

mauritsvanrees added a commit to plone/plone.app.contentlisting that referenced this issue Nov 23, 2015

mauritsvanrees added a commit to plone/plone.app.discussion that referenced this issue Nov 23, 2015

mauritsvanrees added a commit to plone/plone.app.event that referenced this issue Nov 23, 2015

mauritsvanrees added a commit to plone/plone.app.querystring that referenced this issue Nov 23, 2015

mauritsvanrees added a commit that referenced this issue Nov 23, 2015

In tests, use 'selection.any' in querystrings.
And expect this in the default news and events collections.

Note that a change in mockup should also be done, ending up in
Products/CMFPlone/static/plone-logged-in-compiled.js

Issue #1040
@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Nov 23, 2015

This is the list of pull requests:

https://github.com/plone/Products.ATContentTypes/pull/27
https://github.com/plone/plone.app.contenttypes/pull/300
https://github.com/plone/mockup/pull/613
https://github.com/plone/plone.app.contentlisting/pull/12
https://github.com/plone/plone.app.discussion/pull/76
https://github.com/plone/plone.app.event/pull/207
https://github.com/plone/plone.app.querystring/pull/57
https://github.com/plone/Products.CMFPlone/pull/1259

Jenkins for all those together: http://jenkins.plone.org/job/pull-request-5.0/582/

mauritsvanrees added a commit to plone/plone.app.querystring that referenced this issue Nov 23, 2015

Again upgrade collections with selection.is to selection.any.
The standard events and news collections may have been wrongly created
in a new site.

Issue plone/Products.CMFPlone#1040
@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Nov 23, 2015

Jenkins is not finished yet, but let's start another one as I added migration.
http://jenkins.plone.org/job/pull-request-5.0/583/

@fulv

This comment has been minimized.

Copy link
Member Author

fulv commented Nov 23, 2015

👏

@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Nov 23, 2015

Both Jenkins runs passed successfully.

frapell added a commit to plone/buildout.coredev that referenced this issue Nov 23, 2015

[fc] Repository: mockup
Branch: refs/heads/master
Date: 2015-11-23T15:06:01+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/mockup@c281fc1

Use selection.any in querystring pattern.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M mockup/patterns/relateditems/pattern.js
M mockup/tests/json/queryStringCriteria.json
Repository: mockup
Branch: refs/heads/master
Date: 2015-11-23T15:09:22-03:00
Author: Franco Pellegrini (frapell) <frapell@gmail.com>
Commit: plone/mockup@ac693c0

Merge pull request #613 from plone/cmfplone-issue-1040

Use selection.any in querystring pattern.

Files changed:
M CHANGES.rst
M mockup/patterns/relateditems/pattern.js
M mockup/tests/json/queryStringCriteria.json

gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 25, 2015

[fc] Repository: plone.app.contenttypes
Branch: refs/heads/master
Date: 2015-11-23T15:04:18+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.contenttypes@560ff48

Create standard news/events collections with selection.any.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M plone/app/contenttypes/setuphandlers.py
M plone/app/contenttypes/tests/test_content_profile.py
Repository: plone.app.contenttypes
Branch: refs/heads/master
Date: 2015-11-25T11:37:37+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/plone.app.contenttypes@fe1d27e

Merge pull request #300 from plone/cmfplone-issue-1040

Create standard news/events collections with selection.any.

Files changed:
M CHANGES.rst
M plone/app/contenttypes/setuphandlers.py
M plone/app/contenttypes/tests/test_content_profile.py

gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 25, 2015

[fc] Repository: plone.app.contentlisting
Branch: refs/heads/master
Date: 2015-11-23T15:06:55+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.contentlisting@6e52e6e

In tests, use ``selection.any`` in querystrings.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M plone/app/contentlisting/tests/test_integration_unit.py
Repository: plone.app.contentlisting
Branch: refs/heads/master
Date: 2015-11-25T11:38:04+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/plone.app.contentlisting@d19e36d

Merge pull request #12 from plone/cmfplone-issue-1040

In tests, use ``selection.any`` in querystrings.

Files changed:
M CHANGES.rst
M plone/app/contentlisting/tests/test_integration_unit.py

gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 25, 2015

[fc] Repository: plone.app.querystring
Branch: refs/heads/master
Date: 2015-11-23T15:10:12+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.querystring@6638983

In tests, use 'selection.any' in querystrings.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M plone/app/querystring/tests/testQueryBuilder.py
Repository: plone.app.querystring
Branch: refs/heads/master
Date: 2015-11-23T16:03:14+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.querystring@bc73cd3

Again upgrade collections with selection.is to selection.any.

The standard events and news collections may have been wrongly created
in a new site.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M plone/app/querystring/upgrades.py
M plone/app/querystring/upgrades.zcml
Repository: plone.app.querystring
Branch: refs/heads/master
Date: 2015-11-25T11:38:46+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/plone.app.querystring@a40b003

Merge pull request #57 from plone/cmfplone-issue-1040

In tests, use 'selection.any' in querystrings.

Files changed:
M CHANGES.rst
M plone/app/querystring/tests/testQueryBuilder.py
M plone/app/querystring/upgrades.py
M plone/app/querystring/upgrades.zcml
@gforcada

This comment has been minimized.

Copy link
Contributor

gforcada commented Nov 25, 2015

Merged the ones that do not have merge conflicts so far. Great job as usual!

mauritsvanrees added a commit to plone/Products.ATContentTypes that referenced this issue Nov 25, 2015

gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 25, 2015

[fc] Repository: Products.ATContentTypes
Branch: refs/heads/master
Date: 2015-11-25T11:38:45+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.ATContentTypes@9e760fb

Create standard news/events collections with selection.any.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M Products/ATContentTypes/setuphandlers.py
Repository: Products.ATContentTypes
Branch: refs/heads/master
Date: 2015-11-25T11:41:25+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/Products.ATContentTypes@00b3003

Merge pull request #27 from plone/cmfplone-issue-1040

Create standard news/events collections with selection.any.

Files changed:
M CHANGES.rst
M Products/ATContentTypes/setuphandlers.py

mauritsvanrees added a commit to plone/plone.app.discussion that referenced this issue Nov 25, 2015

gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 25, 2015

[fc] Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-11-25T11:40:06+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.discussion@e5d6916

In tests, use ``selection.any`` in querystrings.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M plone/app/discussion/tests/collection-integration-test.txt
Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-11-25T11:42:42+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/plone.app.discussion@d73e5cb

Merge pull request #76 from plone/cmfplone-issue-1040

In tests, use ``selection.any`` in querystrings.

Files changed:
M CHANGES.rst
M plone/app/discussion/tests/collection-integration-test.txt

mauritsvanrees added a commit to plone/plone.app.event that referenced this issue Nov 25, 2015

gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 25, 2015

[fc] Repository: plone.app.event
Branch: refs/heads/master
Date: 2015-11-25T11:40:56+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.event@ea50f6c

In tests, use ``selection.any`` in querystrings.

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M plone/app/event/tests/base_setup.py
M plone/app/event/tests/test_event_listing.py
Repository: plone.app.event
Branch: refs/heads/master
Date: 2015-11-25T11:43:34+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/plone.app.event@0d6aea4

Merge pull request #207 from plone/cmfplone-issue-1040

In tests, use ``selection.any`` in querystrings.

Files changed:
M CHANGES.rst
M plone/app/event/tests/base_setup.py
M plone/app/event/tests/test_event_listing.py

mauritsvanrees added a commit that referenced this issue Nov 25, 2015

In tests, use 'selection.any' in querystrings.
And expect this in the default news and events collections.

Note that a change in mockup should also be done, ending up in
Products/CMFPlone/static/plone-logged-in-compiled.js

Issue #1040

gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 25, 2015

[fc] Repository: Products.CMFPlone
Branch: refs/heads/master
Date: 2015-11-25T11:43:05+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.CMFPlone@68329e3

In tests, use 'selection.any' in querystrings.

And expect this in the default news and events collections.

Note that a change in mockup should also be done, ending up in
Products/CMFPlone/static/plone-logged-in-compiled.js

Issue plone/Products.CMFPlone#1040

Files changed:
M CHANGES.rst
M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_syndication.py
M Products/CMFPlone/tests/testPortalCreation.py
Repository: Products.CMFPlone
Branch: refs/heads/master
Date: 2015-11-25T11:43:05+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.CMFPlone@c9842ee

Manually do the 'selection.is/any' change in the js.

Just search and replace.

Files changed:
M Products/CMFPlone/static/plone-logged-in-compiled.js
M Products/CMFPlone/static/plone-logged-in-compiled.min.js
Repository: Products.CMFPlone
Branch: refs/heads/master
Date: 2015-11-25T11:45:48+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/Products.CMFPlone@9abfa6c

Merge pull request #1259 from plone/cmfplone-issue-1040

Use and expect selection.any instead of selection.is. Issue 1040

Files changed:
M CHANGES.rst
M Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_syndication.py
M Products/CMFPlone/static/plone-logged-in-compiled.js
M Products/CMFPlone/static/plone-logged-in-compiled.min.js
M Products/CMFPlone/tests/testPortalCreation.py
@gforcada

This comment has been minimized.

Copy link
Contributor

gforcada commented Nov 25, 2015

All of them merged! Great work!

@gforcada gforcada closed this Nov 25, 2015

@mauritsvanrees

This comment has been minimized.

Copy link
Member

mauritsvanrees commented Nov 25, 2015

Thanks for merging, Gil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.