Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passwordreset form requires email address case match #1449

Open
tkimnguyen opened this issue Mar 8, 2016 · 5 comments
Open

passwordreset form requires email address case match #1449

tkimnguyen opened this issue Mar 8, 2016 · 5 comments

Comments

@tkimnguyen
Copy link
Sponsor Member

If you create a new user and specify an email address that has capital letters (e.g. Nguyen@plone.org), the new user receives an email with a link to the passwordreset form. The passwordreset form should ignore case (RFC822) but does not. Instead if the case of the email address you enter on the form does not match case exactly (e.g. nguyen@plone.org, you get this unhelpful error:

Error setting password
Sorry, this appears to be an invalid request. Please make sure you copied the URL exactly as it appears in your email and that you entered your email address correctly.

Also begs the question: if the URL the user clicks on contains their email address, why are we asking them to re-enter their email address? e.g. https://mysite/passwordreset/aaa8234bbb1324eee?userid=Nguyen@plone.org

@vangheem
Copy link
Member

vangheem commented Mar 8, 2016

This happens when you use email as username setting.

@mauritsvanrees
Copy link
Sponsor Member

Which Plone version is this? On Plone 5 I expect this to work, because we ignore the case.
On Plone 4, you can add collective.emaillogin4 to the eggs for some fixes.
See https://pypi.python.org/pypi/collective.emaillogin4
and #1387

@tkimnguyen
Copy link
Sponsor Member Author

This was for Plone 4.3.3. Thanks @mauritsvanrees. Is it worth making the fix in the 4.3 line?

@mauritsvanrees
Copy link
Sponsor Member

No, I think not, the fixes are too invasive.

@tkimnguyen
Copy link
Sponsor Member Author

OK I'll split out this into a separate issue if you think it's worth pursuing:

if the URL the user clicks on contains their email address, why are we asking them to re-enter their email address? e.g. https://mysite/passwordreset/aaa8234bbb1324eee?userid=Nguyen@plone.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants